macOS performance regression in 20180422134221

[Former user]

20180422134221 and previous macOS release introduce a performance regression.

Loading a complex pattern now keeps Valentina at 100% of a single core.

Pattern + measurement file emailed out-of-band.

[Former user]

Update. This may be pattern-specific and not Valentina version-specific.

[Roman Telezhynskyi]

Do you do something specifical, i cannot reproduce on Linux?

[Roman Telezhynskyi]

The Link to commit is broken.

[Former user]

Just loading the pattern and selecting 'Jacket' piece causes the CPU to spin 100% and the entire interface is unresponsive.

I tested both with and without OpenGL.

I'm running Git:1ec0989.

Tested on two macs, both are very slow to load the pattern. The pattern was not edited since 20th of March so I'm not sure when this started happening.

[Roman Telezhynskyi]

Okay, i pushed the latest changes to github. Don't think it will change something though. I'll go to try to reproduce the issue on mac.

[Former user]

Thanks.

I'm seeing more weirdness.

Two Macs, both running macOS 10.13.4 (17E199) -- today's update. One is a mac mini (Late 2012), the other one a macbook pro retina (MacBook Pro (13-inch, 2017, Two Thunderbolt 3 ports)).

Both have SSD storage, both run on high-resolution screens (the mini is on a 4k display). Both run Git:1ec0989 Valentina.

Mini loads the pattern file quickly and displays the Jacket fine. I can pan and zoom. The laptop loads the pattern slowly (takes approx 20 seconds to load the pattern) and then freezes when I switch to the Jacket piece with Valentina taking 100% of one core.

I don't know how to troubleshoot this further. Any suggestions welcome.

I'm not even sure if this is a problem with Valentina but other applications work on the laptop just fine. Tested firefox, safari, thunderbird, inkscape, gimp. Only Valentina is spinning out of control. I also tested on another pattern file (available on the Internet). Same problem. I will attach the other pattern here.

[Roman Telezhynskyi]

You can try my package. I cannot reproduce this issue on mac.

Usually i debug this issue very easily. Run Valentina for debugging in Qt Creator, do necessary moves to cause an issue, pause the app with debugger in Qt creator. Place of stop can say us which code constantly cause redrawing. Usually it is some part related to drawing.

[Douglas Caskey]

Since it's my pattern I feel compelled to comment...

The pattern was created / last saved with Seamly2D with pattern schema 0.6.0. The pattern works fine with the Windows build of Seamly2D, my Seamly2D or the latest Valentina (build 0.6.0.778a) on my laptop. My first suggestion would be to load the original - if you haven't saved over it - and see if still causes the issue.

My second suggestion is try an earlier ver of Valentina... preferably the version using the 0.6.0 pattern schema.

I don't use a Mac so I'm not familiar if there are any differences with Qt builds for a Mac to cause this issue - otherwise I'd take a look and see if I could repeat the issue.

Note... You may find the formulas used confusing as the pattern was a proof of concept to input an existing pattern using a method I came up with to enter the grade points and using the @ChestScale in the formulas to grade the points up/dn based on a standard 2" grade.

[Roman Telezhynskyi]

Confirm. Can reproduce, but not always. Hiding control points stop redrawing.

[Roman Telezhynskyi]

Adjust line to control point according to scale. ref #842.

→ <<cset 5f5e9db45094>>

[Roman Telezhynskyi]

Do not send geometry changes when set control point line. ref #842.

→ <<cset 6f3bd6368bee>>

[Roman Telezhynskyi]

Please, someone who can repeat the issue, test my patches.

[Former user]

Pulled the latest and built it as of 5 minutes ago.

The problem with slowdown when handles are visible is now gone.