Test Strict Mode

[Enthalpy]

Strict mode was recently implemented for AAO. Strict mode will cause the player to interpret bad practice as errors. Since bad practice can be as innocuous as a missing var, code that worked fine previously may no longer run.

Unas's description as to current testing:

For the player, I basically played through the Bright Age of the Law trailer (which uses many features of the display engine, as it was meant to showcase V6) and my own old never-finished trial (which made use of variables, investigations and CEs).

For the editor, I tested adding and removing elements in each tab, and try opening pretty much all panels I could find and create investigation and CE blocks and so on.

Parts of the code which were maybe not tested extensively enough are form elements, player actions, expression engine..

All features should be tested before the next release. This may be a multi-person project.

[Enthalpy]

Typo correction.

I'll add that after #106 is finished, I'll focus on this, but help will be appreciated.

[ThePaSch]

May I suggest running all JS code through JSHint? It has in-built support for strict mode validation and will point to any errors or inconsistencies. It would certainly streamline the process.

It'll throw many errors that aren't actually errors (since it obviously can't know functions that are defined in other files), so it will still take a fair bit of manual review, but it should at least point to the right direction.

[Enthalpy]

I hadn't heard about this. Thanks!

[Enthalpy]

Fixed by pull request #55.