- marked as enhancement
Sonarqube 6.7 (find file attached)
It's Gregoire (issue with admin jobs page), I don't know why I can't go to your page with my entreprise atlassian account anymore...
I have adapted Sonarqube45 plugin to work with 6.7. I don't have writes to open a pull request. Then please find attached the file to put in mojo/lib/Alambic/Plugin/
It's working 🤞 but I don't have tested everything. (I don't feel confident enough to write unitary testing in Perl, I was confused enough between $ % @ etc. !)
I hope you had (have) great holidays and happy new year.
Comments (6)
-
reporter -
reporter - changed component to Plugins
-
repo owner Hi Gregoire,
Thanks a lot for your contributions, and a happy new year to you! I'll review the changes and write the unit tests asap.
As for the access issue, I've added you as a user to the project -- bt this should not be needed to fork and generate a pull request. This needs to be fixed, I'll contact you privately for further testing if you don't mind.
I'll keep you posted, and thanks again. Have a great week! :-)
-
reporter - changed status to closed
Plugins for sonarqube 6.7.x, just a copy of Sonarqube45 with change of API called. Close
#142→ <<cset 26721e1e58a0>>
-
repo owner Hi Gregoire,
Following our discussions, I've updated the plugins/cr142_sonarqube67 branch with: * new tests * new doc * minor fixes and cosmetic changes.
The code for the plugin itself barely changed, so congrats! :-)
You can see the diff here if you'd like.
-
repo owner Merged in plugins/cr142_sonarqube67 (pull request #17)
Plugins for sonarqube 6.7.x, just a copy of Sonarqube45 with change of API called. Close
#142Approved-by: Boris Baldassari
→ <<cset 05dc0c83dac1>>
- Log in to comment