distuils and CMake version issues in ROS Noetic

[Shane Loretz]

It looks like there are a couple issues that would affect this package when released to ROS Noetic. Solutions to both problems are in the ROS Noetic Migration guide.

• The setup.py uses distutils, but that’s not guaranteed to be installed on Ubuntu Focal

  • http://wiki.ros.org/noetic/Migration#Setuptools_instead_of_Distutils

• The CMakeLists.txt uses a very old version of CMake that warns when a certain policy is not set

  • http://wiki.ros.org/noetic/Migration#Increase_required_CMake_version_to_avoid_author_warning

---

The setup.py imports setup from distutils.core, but in Ubuntu Focal distutils is shipped separately in python3-distutils and is not guaranteed to be installed.

https://bitbucket.org/DataspeedInc/oxford_gps_eth/src/79712d85fcd70a3a8ab9d08c69bfd9545f05cf88/setup.py#lines-3

‌

The CMakeLists.txt requires version `2.8.3`, but on Ubuntu Focal CMake will warn that CMP0048 is unset on the second CMake invocation. This happens because the buildfarm first invokes CMake to build the package, and then invokes it again to build and run tests.

https://bitbucket.org/DataspeedInc/oxford_gps_eth/src/79712d85fcd70a3a8ab9d08c69bfd9545f05cf88/CMakeLists.txt#lines-1

[Kevin Hallenbeck]

Fixed in e273ef3 and 7d85ea1