Typo in default rod rotation value
Issue #70
open
By default, generated rods give the following rotation value in FFEA scripts:
<rotation = (0.00, 0.00, 0,00)>
Note the comma instead of a period for the z rotation.
While this does not appear to cause issues with running FFEA simulations, it can cause problems with other tools that use FFEA scripts.
Comments (3)
-
-
- changed status to closed
-
- changed status to open
Commit wasn't supposed to close this yet (whilst I think this is a cause, the wording of this issue suggests there’s a script which I can’t find, will ask Ryan when I next speak with him). Likewise, commit isn’t even to a branch with a PR, should probably be resolved in master/main and whatever builds the website.
- Log in to comment
I just found this same error present in atleast one of the tests (causing stack corruption crashes in my development branch).
https://bitbucket.org/FFEA/ffea/src/rod_vdw/tests/rods/unit/connection_energy_3/
Most of the rod tests are affected.
Present in the example rod file too
https://ffea.readthedocs.io/en/latest/rods.html