1. FFEA Group Avatar FFEA Group
  2. FFEACore
  3. FFEA
  4. Issues

Typo in default rod rotation value

Issue #70 open
Jarvellis Rogers created an issue

By default, generated rods give the following rotation value in FFEA scripts:

<rotation = (0.00, 0.00, 0,00)>

Note the comma instead of a period for the z rotation.

While this does not appear to cause issues with running FFEA simulations, it can cause problems with other tools that use FFEA scripts.

Comments (3)

  1. Robert Chisholm

    I just found this same error present in atleast one of the tests (causing stack corruption crashes in my development branch).

    https://bitbucket.org/FFEA/ffea/src/rod_vdw/tests/rods/unit/connection_energy_3/

    Most of the rod tests are affected.

    # grep -r "0,00" ./tests
./rods/integration/connection/bend.ffea:                <rotation = (0.00, 0.00, 0,00)>
./rods/integration/connection/old/realistic.ffea.old:           <rotation = (0.00, 0.00, 0,00)>
./rods/integration/connection/old/realistic.ffea.old2:          <rotation = (0.00, 0.00, 0,00)>
./rods/integration/connection/old/realistic_reversed.ffea.old:          <rotation = (0.00, 0.00, 0,00)>
./rods/integration/connection/old/realistic_reversed.ffea.old2:         <rotation = (0.00, 0.00, 0,00)>
./rods/integration/connection/twist.ffea:               <rotation = (0.00, 0.00, 0,00)>
./rods/integration/equipartition/realistic.ffea:                <rotation = (0.00, 0.00, 0,00)>
./rods/integration/equipartition/realistic.ffea:                <rotation = (0.00, 0.00, 0,00)>
./rods/integration/equipartition/realistic.ffea:                <rotation = (0.00, 0.00, 0,00)>
./rods/integration/stericInteract_initForceSymmetric/collision_twoRods_singleFrame.ffea:            <rotation = (0.00, 0.00, 0,00)>
./rods/integration/stericInteract_initForceSymmetric/collision_twoRods_singleFrame.ffea:            <rotation = (1.57, 0.00, 0,00)>     < ! -- 1/2 pi rad -- >
./rods/integration/symmetry/symmetry_test_bend_only.ffea:               <rotation = (0.00, 0.00, 0,00)>
./rods/integration/symmetry/symmetry_test_stretch_only.ffea:            <rotation = (0.00, 0.00, 0,00)>
./rods/integration/symmetry/symmetry_test_twist_only.ffea:              <rotation = (0.00, 0.00, 0,00)>
./rods/unit/connection/tet_ascii.1.ffea:                <rotation = (0.00, 0.00, 0,00)>
./rods/unit/connection_energy/realistic.ffea:           <rotation = (0.00, 0.00, 0,00)>
./rods/unit/connection_energy/realistic_reversed.ffea:          <rotation = (0.00, 0.00, 0,00)>
./rods/unit/connection_energy_2/realistic.ffea:         <rotation = (0.00, 0.00, 0,00)>
./rods/unit/connection_energy_2/realistic_reversed.ffea:                <rotation = (0.00, 0.00, 0,00)>
./rods/unit/connection_energy_3/realistic.ffea:         <rotation = (0.00, 0.00, 0,00)>
./rods/unit/connection_energy_3/realistic_reversed.ffea:                <rotation = (0.00, 0.00, 0,00)>
./rods/unit/connection_identify_face/round_lad.1.ffea:          <rotation = (0.00, 0.00, 0,00)>
./rods/unit/connection_orientation/tet_ascii.1.ffea:            <rotation = (0.00, 0.00, 0,00)>
./rods/unit/recover_normal/realistic.ffea:              <rotation = (0.00, 0.00, 0,00)>

    Present in the example rod file too

    https://ffea.readthedocs.io/en/latest/rods.html

  3. Robert Chisholm
    • changed status to open

    Commit wasn't supposed to close this yet (whilst I think this is a cause, the wording of this issue suggests there’s a script which I can’t find, will ask Ryan when I next speak with him). Likewise, commit isn’t even to a branch with a PR, should probably be resolved in master/main and whatever builds the website.

  4. Log in to comment
Assignee
–
Type
bug
Priority
trivial
Status
open
Votes
0
Watchers
1
Jira: the preferred issue tracker for Bitbucket. Join the team!