NINA hung when "loop until sun altitude" should have triggered end of sequence operations

Issue #1052 closed
Cedric Raguenaud created an issue

My sequence (attached) should stop when the sun gets above -16 degrees (I think, unless I’ve done something wrong again). Overnight, when its altitude was 15.99, it hung in the middle of an image taking. I couldn’t stop the sequence by clicking on the stop button or move to the next step. I had to close NINA.

I also attach the sequence and a screenshot. Note the sun altitude in the current target (-15.99) and the real altitude in the next target (-5.82).

Version: 2.0 beta 31

Comments (10)

  1. Stefan B repo owner

    According to the logs, the condition did send an interrupt, but it seems like the camera driver was then stuck cancelling the exposure.

    Can you check if this is a general driver issue, when you are cancelling an ongoing exposure?

  2. George Hilios

    Abort exposure should’ve put the camera in a state where the WaitForExposure loop should exit out, but I do see some ways I can make this more resilient. I’ll prepare the change today.

    Thanks for the clear report, Cedric!

  3. Cedric Raguenaud reporter

    I can definitively cancel exposures, but that's a good explanation. Thanks.

    George, I’m using my driver because I’ve been moving from software to software. So your drive isn’t at fault.

  4. George Hilios

    Oh interesting! So this happened with ASCOM. I’ll check this out too - maybe there’s something we can improve further there.

  5. Cedric Raguenaud reporter

    I’m trying to find out exactly what happened. It hasn’t happened since, so no detailed logs yet.

  6. George Hilios

    From looking at the code, the most likely thing that happened is a call to AbortExposure hung indefinitely within the ASCOM driver. Otherwise the cancellation token would’ve terminated the outer loop. Perhaps look there?

  7. Cedric Raguenaud reporter

    Yes. I suspected it was that, but played with it for a while today and didn’t get any issue. Also I can’t see in the code what could hang as everything has a timeout. I’ll keep looking.

  8. Log in to comment