QHY168c GAin error

[Former user]

here is the log for thr error on No Gain adjustment

[Dale Ghent]

[2019-02-23T12:51:55]    [DEBUG]     [MemberName] Connect
[2019-02-23T12:51:55]    [DEBUG]     [FileName] D:\Projects\nina\NINA\Model\MyCamera\QHYCamera.cs
[2019-02-23T12:51:55]    [DEBUG]     [Message] QHYCCD: GainMin=1, GainMax=15, GainStep=1

[2019-02-23T12:51:55]    [DEBUG]     [MemberName] GetControlValue
[2019-02-23T12:51:55]    [DEBUG]     [FileName] D:\Projects\nina\NINA\Model\MyCamera\QHYCamera.cs
[2019-02-23T12:51:55]    [DEBUG]     [Message] QHYCCD: Got Control CONTROL_GAIN = 1

[2019-02-23T12:51:55]    [DEBUG]     [MemberName] SetControlValue
[2019-02-23T12:51:55]    [DEBUG]     [FileName] D:\Projects\nina\NINA\Model\MyCamera\QHYCamera.cs
[2019-02-23T12:51:55]    [DEBUG]     [Message] QHYCCD: Setting Control CONTROL_GAIN to 15

[2019-02-23T12:51:55]    [DEBUG]     [MemberName] GetControlValue
[2019-02-23T12:51:55]    [DEBUG]     [FileName] D:\Projects\nina\NINA\Model\MyCamera\QHYCamera.cs
[2019-02-23T12:51:55]    [DEBUG]     [Message] QHYCCD: Got Control CONTROL_GAIN = 1

During camera connect, we asked the SDK for the camera gain and it reported a value of 1. We then set the gain to 15 and then ask the SDK to report the gain again, and it still reports a gain of 1. It seems the QHY168C has a bug where it will always report a gain value of 1 no matter what it is set to.

[Dale Ghent]

Background: User reports an issue using their QHY168C in NINA, where the gain would appear to be unsettable.

[Dale Ghent]

Tested solution: Change the QuirkDiv10 function to a more general "Gain reporting lies in some way" function, and track the set gain locally if we encounter a camera that misreports it in whatever fashion. Candidate solution that implements this was tested and verified with the original bug reporter @lazypineapple in Discord. Patch incoming.

[Dale Ghent]

Fixed with 83d68ba