Optimal exposure time is way higher than maximum recommended exposure time

Issue #394 resolved
Shlomi Vaknin created an issue

Unless I am missing something, or didn't RTFM close enough, there seem to be some mismatch between the optimal and max exposure times:

Version is 1.10 Nightly #035

Comments (2)

  1. Shlomi Vaknin reporter

    Looking briefly at the code, this could happen since this line https://bitbucket.org/Isbeorn/nina/src/61d9b3f48c29ac541996627ed1b2c1100c33ac6d/NINA/ViewModel/ImageStatisticsVM.cs?at=master#lines-151 may compute a larger value than max, and this line https://bitbucket.org/Isbeorn/nina/src/61d9b3f48c29ac541996627ed1b2c1100c33ac6d/NINA/ViewModel/ImageStatisticsVM.cs?at=master#lines-157 may set it as optimal.

    A simple fix may be

    OptimizedExposureTime = min(recommendedTime, MaximumRecommendedExposureTime);
    

  2. Log in to comment