Instrument:Telescope:FocalLength specification error
I just encountered a problem with the XISF files, due to a misinterpretation of the specifications.
Extraction of specifications
Instrument:Telescope:FocalLength
A Float32 property. The effective focal length of the optical system expressed in meters.
Now the value, put in the files you generate is in mm
in my case:
<Property id="Instrument:Telescope:FocalLength" type="Float32" comment="[mm] Focal length" value="342" />
I should have:
<Property id="Instrument:Telescope:FocalLength" type="Float32" comment="[mm] Focal length" value="0.342" />
If I understand the entire specification.
Comments (9)
-
-
reporter - marked as major
This anomaly blocks the processing of the PhotometricColorCalibration script in Pixinsight
-
reporter Thank you for everything, it's very good work.
-
Here is an example with the fix applied:
<Property id="Instrument:Telescope:Name" type="String" comment="Name of telescope">AP 130GTX</Property> <FITSKeyword name="TELESCOP" value="AP 130GTX" comment="Name of telescope" /> <Property id="Instrument:Telescope:FocalLength" type="Float32" comment="[m] Focal Length" value="0.589" /> <FITSKeyword name="FOCALLEN" value="589" comment="[mm] Focal length" /> <Property id="Instrument:Telescope:Aperture" type="Float32" comment="[mm] Aperture" value="130.888888888889" /> <FITSKeyword name="FOCRATIO" value="4.5" comment="Focal ratio" />
-
It looks like Aperture is also expressed in meters in XISF’s properties.
-
reporter Thank You !
Now I'll have to write a script with pixinsight, to correct all my pictures. -
Ok, the Aperture image property is also fixed:
<Property id="Instrument:Telescope:Name" type="String" comment="Name of telescope">AP 130GTX</Property> <FITSKeyword name="TELESCOP" value="AP 130GTX" comment="Name of telescope" /> <Property id="Instrument:Telescope:FocalLength" type="Float32" comment="[m] Focal Length" value="0.589" /> <FITSKeyword name="FOCALLEN" value="589" comment="[mm] Focal length" /> <Property id="Instrument:Telescope:Aperture" type="Float32" comment="[m] Aperture" value="0.130888888888889" /> <FITSKeyword name="FOCRATIO" value="4.5" comment="Focal ratio" />
-
Fix is in pull request #487 and will be in the next 1.10 nightly.
-
repo owner - changed status to resolved
- Log in to comment
Yep. you are right. A little oversight. I’ll submit a patch shortly to divide the value by 1000 before inserting it. Thanks for catching this.