Instrument:Telescope:FocalLength specification error

Issue #479 resolved
Pascal Bousquet created an issue

I just encountered a problem with the XISF files, due to a misinterpretation of the specifications.

Extraction of specifications
Instrument:Telescope:FocalLength
A Float32 property. The effective focal length of the optical system expressed in meters.

Now the value, put in the files you generate is in mm

in my case:
<Property id="Instrument:Telescope:FocalLength" type="Float32" comment="[mm] Focal length" value="342" />
I should have:
<Property id="Instrument:Telescope:FocalLength" type="Float32" comment="[mm] Focal length" value="0.342" />

If I understand the entire specification.

Comments (9)

  1. Dale Ghent

    Yep. you are right. A little oversight. I’ll submit a patch shortly to divide the value by 1000 before inserting it. Thanks for catching this.

  2. Dale Ghent

    Here is an example with the fix applied:

        <Property id="Instrument:Telescope:Name" type="String" comment="Name of telescope">AP 130GTX</Property>
        <FITSKeyword name="TELESCOP" value="AP 130GTX" comment="Name of telescope" />
        <Property id="Instrument:Telescope:FocalLength" type="Float32" comment="[m] Focal Length" value="0.589" />
        <FITSKeyword name="FOCALLEN" value="589" comment="[mm] Focal length" />
        <Property id="Instrument:Telescope:Aperture" type="Float32" comment="[mm] Aperture" value="130.888888888889" />
        <FITSKeyword name="FOCRATIO" value="4.5" comment="Focal ratio" />
    

  3. Pascal Bousquet reporter

    Thank You !
    Now I'll have to write a script with pixinsight, to correct all my pictures.

  4. Dale Ghent

    Ok, the Aperture image property is also fixed:

        <Property id="Instrument:Telescope:Name" type="String" comment="Name of telescope">AP 130GTX</Property>
        <FITSKeyword name="TELESCOP" value="AP 130GTX" comment="Name of telescope" />
        <Property id="Instrument:Telescope:FocalLength" type="Float32" comment="[m] Focal Length" value="0.589" />
        <FITSKeyword name="FOCALLEN" value="589" comment="[mm] Focal length" />
        <Property id="Instrument:Telescope:Aperture" type="Float32" comment="[m] Aperture" value="0.130888888888889" />
        <FITSKeyword name="FOCRATIO" value="4.5" comment="Focal ratio" />
    

  5. Log in to comment