QHY- Crash during autofocus with "inner crop ratio" option and a color camera

Issue #596 resolved
Daniel Lorenzo created an issue

When starting my sequence, app is now crashing after succesful platesolve.

I just discovered it was due to the autofocus option “AF Inner Crop Ratio”.

Tried setting it to 0.75

Setting back to default 1 fixes the issue.

However, instead of crashing, the app should show an error message and/or append to log

Comments (16)

  1. Stefan B repo owner

    Please attach your log file.
    Ideally set the log file to trace, reproduce your issue and then add it to the issue. Furthermore a more in-depth description of your problem would be beneficial. Which camera etc.

    Thanks.

  2. Daniel Lorenzo reporter

    I’ve set the logs level to “trace” set the value of “AF Inner Crop Ratio” to 0.75 and restarted the app (would not cause the crash otherwise, I think option is read only at app startup?).

    Reproduced the crash and attached the log (above).

    To reproduce the problem after the restart to enable my option changes, I went minimal:

    1. Connect the camera
    2. Connect the autofocus
    3. Go to “Imaging” section
    4. Go to “Autofocus” tab
    5. Launch autofocus
    6. Once exposure and debayering is done ..BOOM!

  3. Daniel Lorenzo reporter

    I’ve putted back the value to 0.75

    1. Tested by disabling the option “Debayered HFR”, it still crashed
    2. Tested by disabling the option “Debayer Image”, it did not crash and the autofocus started moving to next position

    So it is confirming that the debayer operation is causing a problem.

    My camera is a QHY294C, on a fresh NINA 1.10 install (3 days old).

    I’m connecting using the native driver, not ASCOM.

    Fortunately, I don’t absolutely need that feature. I was interested to see if that would give better results since I’m mounted on a C11 Edge HD with Hyperstar and I have substantial vignetting.

  4. Stefan B repo owner

    Hmm yea sub sampling with a bayer matrix will shred the bayer matrix as not the complete data is availabl... That could cause a problem during the debayer process.

  5. Daniel Lorenzo reporter

    True! with debayer and a value of 0.75, for a usual 2x2 color pixels, it should match half the resolution, something like:
    resolutionWidthOrHeight / 2 * 0.75 * 2

    Work all coordinates at half resolution then put them at original

  6. Javier Villarreal

    Daniel, is it possible you could pass the setup parameters for autofocus in NINA?. I have the same exact equipment, C11 with a Rigel Systems nStep Focuser. i’ll appreciate it very much.

  7. Paul Garais

    Just want to confirm, that the exact same issue is also present in current nightly build. Tried it last night (18.06.2021/19.06.2021). I am using a QHY268C with the native driver. A inner crop ratio of 0.5 or 1 is working fine, while 0.75 leads to instant crashes.

  8. Stefan B repo owner

    Does this still happen with the latest nightly? There might have been some changes to prevent this.

  9. Log in to comment