Nightly 19: Crashes when saving User Tamplate

[Ruediger]

[Y] Is the issue reproducible?
[Y] Are you running the latest version?
[Y] Are all prerequisites that are mentioned inside the manual met?

Description

NINA gets closed when saving User-Templates

Steps to Reproduce

• Start NINA, Connect ASCOM simulators
• Load target in old Sequencer and transfer it to advanced Sequencer
• Delete cooling camera and drag and drop own Startup Instructions Set
• Save Startup block via Icon
• after a few seconds NINA gets closed

Expected behaviour

save Instruction Set

Actual behaviour

NINA gets closed without any EM

Log attached, but no entry.

[Ruediger]

Saving set closes NINA after a few seconds

[Stefan B]

Make sure the folder to save templates to is accessible. In the meantime i can add error robustness to see where the root cause is.

[Ruediger]

It is accessible, since when restarting NINA I see the block was saved. It looks like it crashes after writing.

Also I noticed that sometimes the overwriting warning comes, sometimes not,

[Ruediger]

BTW: Drag and drop does not work. I cannot drag any item to the right side.

[Stefan B]

check in version 20 if you get errors and then attach the logs again. thanks.

[Ruediger]

Installed and checked. When saving it is not crashing anymore, but the template window is empty (screenshots before saving, after saving).

I have to restart NINA to populate it.

Log Contains errors (see below):

‌

[2020-11-13T21:37:57.2719] [DEBUG] [MemberName] GetCameras
[2020-11-13T21:37:57.2719] [DEBUG] [FileName] E:\Projects\nina\NINA\Utility\CameraSDKs\FLISDK\FLICameras.cs
[2020-11-13T21:37:57.2719] [DEBUG] [Message] FLI: Found 0 camera(s)

[2020-11-13T21:37:57.2829] [DEBUG] [MemberName] GetEquipment
[2020-11-13T21:37:57.2829] [DEBUG] [FileName] E:\Projects\nina\NINA\ViewModel\Equipment\Camera\CameraChooserVM.cs
[2020-11-13T21:37:57.2829] [DEBUG] [Message] Adding ToupTek Cameras

[2020-11-13T21:37:57.3069] [DEBUG] [MemberName] GetEquipment
[2020-11-13T21:37:57.3069] [DEBUG] [FileName] E:\Projects\nina\NINA\ViewModel\Equipment\Camera\CameraChooserVM.cs
[2020-11-13T21:37:57.3069] [DEBUG] [Message] Adding Omegon Cameras

[2020-11-13T21:38:00.9761] [DEBUG] [MemberName] GetFilterWheels
[2020-11-13T21:38:00.9761] [DEBUG] [FileName] E:\Projects\nina\NINA\Utility\CameraSDKs\FLISDK\FLIFilterWheels.cs
[2020-11-13T21:38:00.9761] [DEBUG] [Message] FLI: Found 0 filter wheel(s)

[2020-11-13T21:38:00.9841] [DEBUG] [MemberName] GetFilterWheels
[2020-11-13T21:38:00.9841] [DEBUG] [FileName] E:\Projects\nina\NINA\Utility\CameraSDKs\QHYSDK\QHYFilterWheels.cs
[2020-11-13T21:38:00.9841] [DEBUG] [Message] QHYCFW: Found 0 filter wheel(s)

[2020-11-13T21:40:54.7882] [ERROR] [MemberName] LoadUserTemplates
[2020-11-13T21:40:54.7882] [ERROR] [FileName] E:\Projects\nina\NINA\Sequencer\TemplateController.cs
[2020-11-13T21:40:54.7882] [ERROR] [Message] Object reference not set to an instance of an object. at System.Windows.Data.ListCollectionView.PrepareLocalArray()
at System.Windows.Data.ListCollectionView.RefreshOverride()
at System.Windows.Data.CollectionView.RefreshInternal()
at NINA.Sequencer.TemplateController.<LoadUserTemplates>b__30_0()

[2020-11-13T21:40:54.8102] [ERROR] [MemberName] LoadUserTemplates
[2020-11-13T21:40:54.8102] [ERROR] [FileName] E:\Projects\nina\NINA\Sequencer\TemplateController.cs
[2020-11-13T21:40:54.8102] [ERROR] [Message] Object reference not set to an instance of an object. at System.Windows.Data.ListCollectionView.PrepareLocalArray()
at System.Windows.Data.ListCollectionView.RefreshOverride()
at System.Windows.Data.CollectionView.RefreshInternal()
at NINA.Sequencer.TemplateController.<LoadUserTemplates>b__30_0()

‌

‌

[Stefan B]

Hmm as there is no log entry for the user templates loading themselves it looks like the access to the path for the default templates is problematic (e.g. no access). these sit in <your nina installation path>\Sequencer\Examples - I need to add a handler there too for the next build. Maybe tomorrow.

[Ruediger]

Maybe this is important:

‌

‌

[Stefan B]

Yea might be related to the custom folder instead of the standard folder. I will check it tomorrow.

[Ruediger]

Many thanks!

[Stefan B]

Does nightly 21 resolve this issue?

[Ruediger]

Hi Stefan,
yes problem solved. Except the drag’n drop still does not work.

‌

[Stefan B]

You need to drag the header bar, not the expander itself. You will always get a visual indicator when you drag an item along that it works.

[Stefan B]

Removing version: 1.11 Nightly (automated comment)