Damage calculation is off by a fraction of a percentage
Issue #37
new
I've noticed that damage calculation is always a teensy tiny bit short of the actual number. This page explains why:
It looks like the game rounds up one of the calculations before applying additional modifiers, whereas we apply all the modifiers and then round. It's not a big deal, but it'd be nice to be exactly accurate.
Comments (4)
-
reporter
-
repo owner
Yeah, Arkaether mentioned this a while back but I was leery of messing with the rounding in the formula. I erred on the side of understating the numbers a bit and making people less confident, instead of making them waste stamina on a failed burst.
-
reporter
That's fair. Being off by .1% tends to not be a big deal, especially if it's under.
I'll keep poking at it to see if I can get it exactly accurate. I'm close, but not quite there yet.
-
reporter
Improved in pull request #7, but still not 100% accurate. I purposely kept it understated for now.
- Log in to comment
I have a fix for this that gets us exactly right for most instances and closer for others, but still not 100% accurate.