- changed status to resolved
Library craps out when user is deopped
Issue #3
resolved
Not sure how general it is yet, certainly this case breaks it.
Also it doesn't seem to notice when a user is opped.
Traceback (most recent call last):
File "/home/kit/.virtualenvs/possel/lib/python3.4/site-packages/tornado/ioloop.py", line 592, in _run_callback
ret = callback()
File "/home/kit/.virtualenvs/possel/lib/python3.4/site-packages/tornado/stack_context.py", line 275, in null_wrapper
return fn(*args, **kwargs)
File "/home/kit/.virtualenvs/possel/lib/python3.4/site-packages/tornado/iostream.py", line 551, in wrapper
return callback(*args)
File "/home/kit/.virtualenvs/possel/lib/python3.4/site-packages/tornado/stack_context.py", line 275, in null_wrapper
return fn(*args, **kwargs)
File "/home/kit/Programming/possel/pircel/pircel/_dev_client.py", line 33, in handle_line
self.line_callback(line)
File "/home/kit/Programming/possel/pircel/pircel/protocol.py", line 264, in handle_line
handler(prefix, *args)
File "/home/kit/Programming/possel/pircel/pircel/protocol.py", line 314, in on_mode
user.apply_mode_command(channel, command)
File "/home/kit/Programming/possel/pircel/pircel/protocol.py", line 411, in apply_mode_command
raise UnknownModeCommandError('Unknown mode change command "{}", expecting "-" or "+"'.format(command))
pircel.protocol.UnknownModeCommandError: Unknown mode change command "-o", expecting "-" or "+"
Comments (1)
-
reporter - Log in to comment
Parse modes in RPL_NAMREPLY, fixes
#3We were crapping out because we didn't know the user had mode +o, now we pull "@ nick" and "+nick" out of RPL_NAMREPLY so we know they're opped.
Also add better exception for if this happens again; "UnkownModeCommandError" is very wrong in this case.
→ <<cset 8cde23bc5fae>>