Invalid Inspection issues are not being raised: Method can be made static

[Jason van Beukering]

• Appears to be a regression, that in certain circumstances the code inspector is providing a hint that a method can be made static.
• I have attached an example from my code base where its clear the hint is wrong

‌

[Scott Wells]

Thanks for logging. There was a change to encapsulate the way that declaration reference searching occurs, so I'm sure that would account for the regression. Should be easy to reproduce and fix given the provided example.

[Scott Wells]

I am curious as to why my own regression test suite didn’t catch it, but I’ll augment as necessary.

[Scott Wells]

Hmmmm…I’m unable to reproduce this behavior locally, but perhaps my example is too simple. Does it reproduce for you with just the following?

public with sharing class Issue2369
{
    private final Object value;

    public String toStringPretty()
    {
        return JSON.serializePretty(value);
    }
}

If not, can you provide a very simple, standalone reproduction?

[Jason van Beukering]

Hi Scott, I’ll email you the full file.. its an open source file which I’ve cleaned up etc. Hopefully it then re-occurs. Btw, we’re seeing this issue in MANY files now.

[Jason van Beukering]

I did try the example above, but didn’t result in the inspection in question.

[Scott Wells]

Thank for the example. Unfortunately I still don’t see that issue with it. Once I stubbed the CMN_UTIL_Date methods that were referenced, I only see that its members are unused:

‌

and to confirm, all of the Apex inspections are enabled:

‌

I hate to ask you to do this, but can you reset the caches/indices using File > Invlidate Caches… and see if that resolves the issue? Perhaps something is wedged in a bad state for you?

[Scott Wells]

With Jason’s help, reproduced this locally as a regression introduced in 2.2.7.0 and I’ve already committed a fix for it. Worst-case scenario it’ll be in next Thursday’s build, but if it’s causing issues for multiple folks, I may issue a hotfix earlier in the week.

[Scott Wells]

Delivered in 2.2.7.1.