Lock out if password is wrong

Issue #298 resolved
Torsten Rost created an issue

If I change my password or reset my security token and forget to do the same in IC, IC tries endless to connect with the wrong data ... until my user is locked out. That can be a problem ;-)

If IC gets a "wrong username or password" from salesforce, it should not try to reconnect until the password and/or security token was changed.

Comments (13)

  1. Scott Wells repo owner

    This one is a bit tricky. The error code/message that comes back from the API when you have invalid credentials is the exact same as the one that you get when you have an expired session ID. Right now IC's API client reacts to that by resetting the session via logout/login to provide a more seamless experience across long sessions. However, if the real reason for the error is a bad login, this can lead to a retry storm that results in having the account locked. I'm planning to change this to do exactly one retry and, if it yields the same results, prompt the user to edit credentials before issuing any further API calls.

  2. Scott Wells repo owner

    This should be resolved now (actually should have been quite a bit back). There's one additional corner case that I plan to address where the login result says the password is expired, but the scenario of an incorrect password/token due to a change outside the IDE should result in being prompted to update your credentials now.

  3. Eric Alexander

    @RoseSilverSoftware May be related but a retry storm happens when no internet connection as well. Was on a plane with several projects open before I boarded. When I reopened IntelliJ Idea I had a storm of no connection messages keep appearing. Not sure if you fixed it with this fix.

    I have not tested on the latest version though.

  4. Former user Account Deleted

    Eric:

    Any chance your laptop automatically joined the inflight wifi but you didn't sign onto a session?

    I have seen a similar issue under two conditions:

    1. I set my laptop to use a proxy at a client set and didn't turn it off at home/another site.
    2. I'm on a public wifi with a capture page and I haven't acknowledged the capture page yet.
  5. Log in to comment