Only the first of duplicate row and column labels are highlighted in a search

[Robert Leach]

USE CASE: WHAT DO YOU WANT TO DO?

Search for all rows matching search string "CCR*"

STEPS TO REPRODUCE AN ISSUE (OR TRIGGER A NEW FEATURE)

1. Open the 6kx6x test matrix (containing many duplicate labels)
2. Enter "CCR*" into the row search field and hit return.

CURRENT BEHAVIOR

Only the first occurrence of each matching row is highlighted.

EXPECTED BEHAVIOR

All matching rows are highlighted (approximately 90 rows)

DEVELOPERS ONLY SECTION SUGGESTED CHANGE (Pseudocode optional)

Not sure. Need to account for the labels not being unique.

FILES AFFECTED (where the changes will be implemented) - developers only

HeaderFinderBox ColumnFinderBox RowFinderBox

LEVEL OF EFFORT - developers only

major

COMMENTS

[Robert Leach]

Resolves issue #280. All search results with duplicate IDs are highlighted now.

The loop that checks for matches was using indexof() which only returns the index of the first matching item in the array, so I changed the loop to cycle through indexes and if there was a match, it adds the index of the current loop iteration.

→ <<cset 6579b7e64350>>

[Robert Leach]

Resolves issue #280. All search results with duplicate IDs are highlighted now.

The loop that checks for matches was using indexof() which only returns the index of the first matching item in the array, so I changed the loop to cycle through indexes and if there was a match, it adds the index of the current loop iteration.

→ <<cset 6579b7e64350>>

[Robert Leach]

Merged in issue280-dupe_id_search_problem (pull request #21)

Resolves issue #280. All search results with duplicate IDs are highlighted now.

→ <<cset 665f8578ff87>>

[Robert Leach]

Merged to master.

[Robert Leach]

Removing milestone: Search (automated comment)