Canceling color settings when no change was made updates the colors

[Robert Leach]

USE CASE: WHAT DO YOU WANT TO DO?

Feel confident (as a user) that not having made a change and canceling the color settings dialog didn't actually do anything to my colors.

STEPS TO REPRODUCE AN ISSUE (OR TRIGGER A NEW FEATURE)

1. Open the color settings
2. Click cancel

CURRENT BEHAVIOR

A little dialog window shows up that says it's updating pixels.

EXPECTED BEHAVIOR

Canceling without having made a change should dismiss the dialog window without (visibly indicating that it's) doing anything to the pixel color settings.

DEVELOPERS ONLY SECTION

SUGGESTED CHANGE (Pseudocode optional)

Either don't show the updating pixels window or track when no change has been made and decide whether an update of the pixels is necessary.

FILES AFFECTED (where the changes will be implemented) - developers only

unknown

LEVEL OF EFFORT - developers only

minor

COMMENTS

Really trivial issue, but one of user confidence in the tool.

[Christopher Keil]

Just to explain: This intentionally happens as a result of live-updating colors. I have not distinguished between whether changes have been made or not, cancel will currently always lead to resetting and repainting. I could certainly track if changes have been made and if not, nothing would happen.

But if colors were changed, a thumb was added o moved, then the reverting needs to take place.

[Robert Leach]

Yeah, I get it. When I created the issue, I didn't think anything was wrong with the way you did it. I understand it and I believe it's a reliable implementation. I was just thinking from a user experience perspective - like they click cancel without thinking, see the update occurring, and thinking "Oh no, did I actually click save by accident?". That's all I was thinking.

[Christopher Keil]

Yes absolutely true. I think it would be good for us to implement it the way you described and it should be a minor effort.

[Christopher Keil]

Merge branch 'master' into issue-#483

accidentally committed changes intended for this branch to master

resolves #483

→ <<cset 6183507e85dd>>