Failure on FreeBSD: error: use of undeclared identifier 'WIFEXITED'

[Yuri Vic]

/usr/ports/graphics/art/work/agriggio-art-b2d77c8f0080/rtengine/subprocess.cc:285:15: error: use of undeclared identifier 'WIFEXITED'
        if (!(WIFEXITED(exit_status) && WEXITSTATUS(exit_status) == 0)) {
              ^
/usr/ports/graphics/art/work/agriggio-art-b2d77c8f0080/rtengine/subprocess.cc:285:41: error: use of undeclared identifier 'WEXITSTATUS'
        if (!(WIFEXITED(exit_status) && WEXITSTATUS(exit_status) == 0)) {
                                        ^
6 warnings and 2 errors generated.

sys/wait.h needs to be included:

$ grep -r WIFEXITED /usr/include/
/usr/include/sys/wait.h:#define WIFEXITED(x)    (_WSTATUS(x) == 0)

‌

[agriggio]

Thanks for reporting. However, I cannot commit to supporting BSD, I just don’t have the manpower to do that. Patches are welcome though…

[Yuri Vic]

Based on the manpage https://man7.org/linux/man-pages/man2/waitid.2.html Linux also requires inclusion of

       #include <sys/types.h>
       #include <sys/wait.h>

for WIFEXITED, WEXITSTATUS, etc.

‌

If it doesn’t complain during compilation - it passes it by luck because these headers happen to be included elsewhere.

‌

[agriggio]

added missing #includes

Fixes #142

→ <<cset b9a467485e6a>>