ART crashing when moving pointer while zooming

Issue #200 resolved
Hombre created an issue

I’ve got occasional crash when moving the pointer while RT is updating the preview. ART segfaults on this line.

I’ve spend several hours to track it down, but everything looked fine. It seems to be a Mutex issue, but the code looks correct.

cropHandler.cropPixbuftrue->get_pixels() seem to be correct, but pix is out of range. cropHandler.cropPixbuftrue has not the size reported by cropimg_width and cropimg_height when it halted, it rather had the previous dimensions. Maybe there’s some race condition with CropHandler::redraw_needed, I don’t know.

I think I managed to find a workaround or fix the bug by deleting cropPixbufTrue early. Though I had no crash for 1 hour now while developing several images (it usually was crashing before 5mn of use), I can’t guarantee that it’s really fixed. The side effect of the fix is that the Navigator don’t show RG/Lab/Lch values anymore while the preview image is being processed, but I don’t think it’s a problem since the values where irrelevant in this situation…

You can find the fix and test it with my zoom-crash branch.

(The AboutThisBuild file is your master branch with my fix)

Comments (4)

  1. agriggio repo owner

    Thanks. I had also tried to pinpoint this in the past, but with no luck 😞 I’ll apply your patch and let’s hope it solves it!

  2. Log in to comment