Windows compiling warnings that might prove interesting to check

Hi Alberto,

Compiling on Windows with msys2 raises some warnings that might be interesting to check:

Git checkout information:
-- Commit description: 1.11
-- Branch: master
-- Commit: 3adbd237e
-- Commit date: 2021-11-30
-- Commits since tag: 0
-- Commits since branch: 0
-- Version (unreliable): 1.11

‌

[ 9%] Building CXX object rtengine/CMakeFiles/rtengine.dir/eahd_demosaic.cc.obj
M:/code/art/rtengine/dfmanager.cc: In member function 'rtengine::dfInfo* rtengine::DFManager::addFileInfib::ustring&, bool)':
M:/code/art/rtengine/dfmanager.cc:363:41: warning: 'this' pointer is null [-Wnonnull]
363 | if (!info && info->get_file_type() == Gio::FILE_TYPE_DIRECTORY) {
| ~~~~~~~^~
In file included from C:/msys64/mingw64/include/giomm-2.4/giomm/fileenumerator.h:31,
from C:/msys64/mingw64/include/giomm-2.4/giomm/file.h:30,
from C:/msys64/mingw64/include/giomm-2.4/giomm/applicationcommandline.h:25,
from C:/msys64/mingw64/include/giomm-2.4/giomm/application.h:30,
from C:/msys64/mingw64/include/giomm-2.4/giomm.h:29,
from C:/msys64/mingw64/include/gtkmm-3.0/gtkmm.h:101,
from M:/code/art/rtgui/options.h:24,
from M:/code/art/rtengine/dfmanager.cc:20:
C:/msys64/mingw64/include/giomm-2.4/giomm/fileinfo.h:588:12: note: in a call to non-static member functiileType Gio::FileInfo::get_file_type() const'
588 | FileType get_file_type() const;

‌

[ 38%] Building CXX object rtengine/CMakeFiles/rtengine.dir/ipfilmsim.cc.obj
M:/code/art/rtengine/metadata.cc: In member function 'void rtengine::Exiv2Metadata::load() const':
M:/code/art/rtengine/metadata.cc:301:102: warning: '(unsigned char)((char*)&val + offsetof(rtengine::Eta::CacheVal, rtengine::Exiv2Metadata::CacheVal::use_xmp))' may be used uninitialized in this function [initialized]
301 | if (cache_ && cache_->get(src_, val) && val.image_mtime >= finfo->modification_time() &&mp == merge_xmp_ && val.xmp_mtime >= xmp_mtime) {
| ~~

‌

[ 76%] Building CXX object rtgui/CMakeFiles/rth.dir/preferences.cc.obj
M:/code/art/rtgui/myflatcurve.cc: In member function 'void MyFlatCurve::getCursorPosition(Gdk::EventTypet, int, Gdk::ModifierType)':
M:/code/art/rtgui/myflatcurve.cc:1627:9: warning: 'prevCursorX' may be used uninitialized [-Wmaybe-unini
1627 | int prevCursorX, prevCursorY;
| ^~~
M:/code/art/rtgui/myflatcurve.cc:1627:22: warning: 'prevCursorY' may be used uninitialized [-Wmaybe-unin
1627 | int prevCursorX, prevCursorY;
| ^~~

‌

Have a nice evening,

Daniel

‌

Comments (2)