Spot removal performance in preview window

[Hombre]

The spot removal tool actually triggers way too much tools in the pipeline, even with the tweak procparams. I replaced the ALLNORAW event by SPOTADJUST, and it’s way more responsive. See patch spot_event.patch attached, (with refreshmap_readability.patch if you don’t mind).

I also see that you commented out some tools that are time consuming (-> disabling time consuming and unnecessary tool). Would you mind if I enable this tweak by a new option in Preferences/Performance ?

[agriggio]

Hi,

thanks for the contribution! I tried it but it doesn’t seem to refresh correctly unfortunately. I tested by first enabling color/tone correction and then trying to add a couple of spots, if that helps.

I also see that you commented out some tools that are time consuming (-> disabling time consuming and unnecessary tool). Would you mind if I enable this tweak by a new option in Preferences/Performance ?

I’m not sure I understand this, can you elaborate?

[Hombre]

Hi,

That’s strange, everything seem to work fine with the patched version here (based on bc6f9d0462f3c88df26b38128a80dbe2bd1ac5c1). Here is a raw file, edit file and output image. I opened the unedited image, enabled color/tone correction (did not bothered to add a mask), then added points.

I’m not sure I understand this, can you elaborate?

I’m speaking about uncommenting everything below this line if the new option is checked in Preferences.

[agriggio]

sorry, I was wrong. It’s not color correction, it’s haze removal. Here’s a video showing what I mean: https://drive.google.com/file/d/15m_LNjfCb9iDU217w2A21dFjF6ZN-DpL/view?usp=share_link

I’m speaking about uncommenting everything below this line if the new option is checked in Preferences.

Honestly I don’t remember why they are commented out – perhaps there was something not working properly (but I’m not sure to be honest). I am against specifying this in preferences though, but if uncommenting the lines does not produce strange side effects, I think the patch can be considered.

[Hombre]

  <div class="preview-container wiki-content"><!-- loaded via ajax --></div>
  <div class="mask"></div>
</div>

</div> </form>

[Hombre]

Speed up Spot tool On Preview operation by changing the events and disabling tools

[Hombre]

Sorry for the comment with patch n°2, I left the default code that was inside the Join box… A bug from Bitbucket ?

spot_event2.patch fix the problem of the Dehaze and Dynamic Range Compression tool, which are involved in the preview update. Using ALLNORAWin EvSpotEnabled seem to suffice. spot_event3.patch does that too but also disable most of the tools, to speed up on preview update even more.

I tested the later one for 5mn (that’s not much, I know), no problem seen so far. If you still see some quirks, using ALLNORAWin EvSpotEnabledOPAshould probably fix it. But again, no problem seen here.

I noticed a bug of the Spot tool when Denoise is Enabled (the pasted image is not denoised), I’ll open an issue later.

[agriggio]

sorry but it still doesn’t work. See the video:

https://drive.google.com/file/d/1pTgC8FCUhGi1u43YAt5J4Zh5LUnlSyOo/view?usp=share_link

raw file from here: https://discuss.pixls.us/t/help-me-stop-fiddling-with-this

[Hombre]

Same as patch 2, but fix the problem. When enabling the Spot tool, the empty spot entries was preventing to create the back-buffer.

[Hombre]

Same as patch 3 but with the bugfix.

[agriggio]

improve spot removal performance in preview window

Patch contributed by Hombre -- thanks! See #286

→ <<cset 8d23704b60e5>>

[agriggio]

Thanks! I’ve applied version 4. Now I remember why I commented out those lines: they change the preview too much, which I’m not sure is expected/desired. That’s why I’d like to keep the behaviour as it is, on a second thought.

[Hombre]

Still no possibility to add it as a Performance option (disabled by default) ? I agree that removing spots would come early in the editing process, but it would be quite useful when copy/pasting a profile and change all the spot positions in the new image.

[agriggio]

Alright, let’s have this as an option then

[Hombre]

Thanks ! I’ll do that this w.e..

[Hombre]

I've thought about a handy integration of this speedup feature through a dedicated button in the Spot tool directly, disabled by default. That way, users are one click away to preview the whole thing at any time.

Just tell me if it's okay for you or if you prefer this option in Preferences.

[agriggio]

in the tool is fine, but its state should not be saved in the arp sidecars IMHO.

[Hombre]

Actually it’s not saved, and I didn’t planed to save it. There’s a comment somewhere that indicate we could store its last state across session in Options (not done yet), but that’s all.

[Hombre]

@agriggio Just in case you missed it, there was a patched attached.

[agriggio]

@Hombre sorry, indeed I missed it! I was reading via email and didn’t notice… I’ll check it out asap, thanks!

[agriggio]

looks good, applied now -- thanks again!