W10/MSYS2 build breaks with last lensfun dev version

Each time a new stable ART version is tagged, I update Lensfun to the last commit of master branch.

Doing that to build ART 1.21.1, I checked out the lensfun version master_v0.3.95-1378-gde21e9fc.

Then the compilation of ART stops with following error :

D:/ART/ARTSOURCE/ART/rtengine/rtlensfun.cc: In destructor 'virtual rtengine::LFModifier::~LFModifier()':
D:/ART/ARTSOURCE/ART/rtengine/rtlensfun.cc:35:16: error: 'struct lfModifier' has no member named 'Destroy'
   35 |         data_->Destroy();
      |                ^~~~~~~
D:/ART/ARTSOURCE/ART/rtengine/rtlensfun.cc: In static member function 'static bool rtengine::LFDatabase::init(const Glib::ustring&)':
D:/ART/ARTSOURCE/ART/rtengine/rtlensfun.cc:320:35: error: 'Create' is not a member of 'lfDatabase'
  320 |     instance_.data_ = lfDatabase::Create();
      |                                   ^~~~~~
D:/ART/ARTSOURCE/ART/rtengine/rtlensfun.cc: In destructor 'rtengine::LFDatabase::~LFDatabase()':
D:/ART/ARTSOURCE/ART/rtengine/rtlensfun.cc:394:16: error: 'struct lfDatabase' has no member named 'Destroy'
  394 |         data_->Destroy();
      |                ^~~~~~~
D:/ART/ARTSOURCE/ART/rtengine/rtlensfun.cc: In member function 'std::unique_ptrrtengine::LFModifier rtengine::LFDatabase::getModifier(const rtengine::LFCamera&, const rtengi
ne::LFLens&, float, float, float, int, int, bool) const':
D:/ART/ARTSOURCE/ART/rtengine/rtlensfun.cc:496:43: error: 'Create' is not a member of 'lfModifier'
  496 |             lfModifier *mod = lfModifier::Create(lens.data_, camera.getCropFactor(), width, height);
      |                                           ^~~~~~
D:/ART/ARTSOURCE/ART/rtengine/rtlensfun.cc:501:26: error: 'struct lfModifier' has no member named 'Initialize'
  501 |             flags = mod->Initialize(lens.data_, LF_PF_F32, focalLen, aperture, focusDist > 0 ? focusDist : 1000, 0.0, LF_RECTILINEAR, flags, false);
      |                          ^~~~~~~~~~
make[2]: *** [rtengine/CMakeFiles/rtengine.dir/build.make:1280: rtengine/CMakeFiles/rtengine.dir/rtlensfun.cc.obj] Error 1

‌

If I come back to lensfun_master_v0.3.95-1344-g03e4a105, compilation of ART is OK.

It seems that in Revision: d67a1f45599dedd6ce686097ddcccc4f3ab83a4b all deprecated entries were removed.

Revision: d67a1f45599dedd6ce686097ddcccc4f3ab83a4b
Author: Joachim Daehnke tuxfanx@gmail.com
Date: 26/12/2023 15:23:12
Message:
Merge pull request #2134 from payano/compile_warnings

Remove some compile warnings, remove deprecated functions

Modified: CMakeLists.txt
Modified: include/lensfun/lensfun.h.in
Modified: libs/lensfun/database.cpp
Modified: libs/lensfun/lens.cpp
Modified: libs/lensfun/mod-coord.cpp
Modified: libs/lensfun/modifier.cpp
Modified: tests/deprecated/test_database_old.cpp
Modified: tests/deprecated/test_modifier_color_old.cpp
Modified: tests/deprecated/test_modifier_coord_centering_old.cpp
Modified: tests/deprecated/test_modifier_coord_distortion_old.cpp
Modified: tests/deprecated/test_modifier_coord_geometry_old.cpp
Modified: tests/deprecated/test_modifier_coord_perspective_correction_old.cpp
Modified: tests/deprecated/test_modifier_coord_scale_old.cpp
Modified: tests/deprecated/test_modifier_coord_tiny_image_old.cpp
Modified: tests/deprecated/test_modifier_old.cpp
Modified: tests/deprecated/test_modifier_regression_old.cpp
Modified: tests/deprecated/test_modifier_subpix_old.cpp
Modified: tests/test_database.cpp
Modified: tests/test_lffuzzystrcmp.cpp
Modified: tests/test_modifier.cpp
Modified: tests/test_modifier_coord_centering.cpp
Modified: tests/test_modifier_coord_distortion.cpp
Modified: tests/test_modifier_coord_geometry.cpp
Modified: tests/test_modifier_coord_perspective_correction.cpp
Modified: tests/test_modifier_coord_scale.cpp
Modified: tests/test_modifier_coord_tiny_image.cpp
Modified: tests/test_modifier_performance.cpp
Modified: tests/test_modifier_regression.cpp
Modified: tests/test_modifier_subpix.cpp

Alberto, do you intend to update ART accordingly? otherwise, I fear I will be stuck with a previous version.

Comments (2)