Build error with AppleClang 7.3.0.7030031

[Carmelo DrRaw]

While testing the automated macOS building on Travis CI, I just encountered the following build error:

‌

/Users/travis/build/aferrero2707/art-win64/art/rtengine/ipspot.cc:116:24: error: value of type 'int __attribute__((ext_vector_type(4)))' (vector of 4 'int' values) is not contextually convertible to 'bool'
            vfloat e = vabsf(upd) > floorv ? vabsf(upd - cur) / vabsf(upd) : ZEROV;
                       ^~~~~~~~~~~~~~~~~~~
1 error generated.

‌

The full build log is available here: https://api.travis-ci.org/v3/job/671989102/log.txt

[agriggio]

spot removal: added missing parentheses

Should fix #43

→ <<cset e2efc6163252>>

[agriggio]

silly mistake, missing parentheses

should be fixed now, can you confirm?

[Carmelo DrRaw]

Still failing:

/Users/travis/build/aferrero2707/art-win64/art/rtengine/ipspot.cc:119:24: error: value of type 'int __attribute__((ext_vector_type(4)))' (vector of 4 'int' values) is not contextually convertible to 'bool'
            vfloat e = (vabsf(upd) > floorv) ? (vabsf(upd - cur) / vabsf(upd)) : ZEROV;
                       ^~~~~~~~~~~~~~~~~~~~~
1 error generated.

It seems that the RT folks fixed a similar issue: https://discuss.pixls.us/t/compiling-on-osx-10-11/1833

The fix: https://github.com/Beep6581/RawTherapee/commit/2d346f670e6bddc5ba9ff81b6a17bc4782c0adbd

‌

[agriggio]

ok, I tried clang and now I also get the error. Will fix soon, thanks!

[agriggio]

now it should work… at least it works here with clang 9

[Carmelo DrRaw]

I confirm the code builds correctly now. A first macOS test package is available from here: https://github.com/aferrero2707/art-win64/releases/tag/continuous

[agriggio]

\o/, thanks a lot!

Any specific instructions on how to use it (e.g. security permissions for the latest version of macOS)?

[Carmelo DrRaw]

A new compilation error has recently appeared with AppleClang:

/Users/travis/build/aferrero2707/art-win64/art/rtengine/metadata.cc:90:12: error: no viable conversion from returned value of type 'std::__1::auto_ptr<Exiv2::Image>' to function return type 'std::unique_ptr<Exiv2::Image>'

    return image;

The full build log can be found here: https://api.travis-ci.org/v3/job/676869499/log.txt

Ping @agriggio

[agriggio]

that’s strange, there should be a move c’tor from auto_ptr to unique_ptr that I thought was standard…maybe I was wrong. I will think of a workaround, thanks!

[agriggio]

my clang version reports no issue (as expected), so I can’t really test, but I believe this patch should work. Can you please try when you have the chance and let me know? Thanks!

[Carmelo DrRaw]

@agriggio your patch works! Log file: https://api.travis-ci.org/v3/job/677204732/log.txt