False positive in Karma plugin.

[Henrik Tilly]

Getting quite some false positive with the karma plugin with mail sent from hotmail. I assume that a lot of crap is coming from hotmail, but this results in "correct" mail getting bounced with: 550 too many recipients for karma -3 (h: )

Example with OK sender and two OK recipients:

2017-06-09 12:06:47 [karma] - fail, tolerated
2017-06-09 12:06:48 [earlytalker] - pass, not spontaneous
2017-06-09 12:06:48 [relay] - skip, no match
2017-06-09 12:06:48 - 220 mail.tilly.se ESMTP
2017-06-09 12:06:48 - dispatching EHLO EUR02-AM5-obe.outbound.protection.outlook.com
2017-06-09 12:06:48 [helo] - karma -1 (-1)
2017-06-09 12:06:48 [helo] - fail, tolerated, no rDNS
2017-06-09 12:06:48 - 250-mail.tilly.se Hi Unknown [172.17.0.1]
2017-06-09 12:06:48 - 250-PIPELINING
2017-06-09 12:06:48 - 250-8BITMIME
2017-06-09 12:06:48 - 250 STARTTLS
2017-06-09 12:06:48 - dispatching STARTTLS
2017-06-09 12:06:48 - 220 Go ahead with TLS
2017-06-09 12:06:48 [tls] - TLS setup returning
2017-06-09 12:06:48 - dispatching EHLO EUR02-AM5-obe.outbound.protection.outlook.com
2017-06-09 12:06:48 [helo] - karma -1 (-2)
2017-06-09 12:06:48 [helo] - fail, tolerated, no rDNS
2017-06-09 12:06:48 - 250-mail.tilly.se Hi Unknown [172.17.0.1]
2017-06-09 12:06:48 - 250-PIPELINING
2017-06-09 12:06:48 - 250-8BITMIME
2017-06-09 12:06:48 - 250 AUTH LOGIN PLAIN
2017-06-09 12:06:48 - dispatching MAIL FROM:<[e-mail]> AUTH=<>
2017-06-09 12:06:49 [dnsbl] - pass
2017-06-09 12:06:49 [rhsbl] - pass
2017-06-09 12:06:49 [badmailfrom] - pass
2017-06-09 12:06:49 [resolvable_fromhost] - pass, hotmail.com has MX at mx2.hotmail.com
2017-06-09 12:06:49 [sender_permitted_from] - karma -1 (-3)
2017-06-09 12:06:49 [sender_permitted_from] - fail, tolerated, soft, hotmail.com: Sender is not authorized by default to use '[e-mail]' in 'mfrom' identity, however domain is not currently prepared for false failures (mechanism '~all' matched)
2017-06-09 12:06:49 - 250 < [e-mail]>, sender OK - how exciting to get mail from you!
2017-06-09 12:06:49 - dispatching RCPT TO:<[e-mail]>
2017-06-09 12:06:49 [rcpt_database] - ok, user <[e-mail]> found in user database
2017-06-09 12:06:49 - 250 <[e-mail]>, recipient ok
2017-06-09 12:06:49 - dispatching RCPT TO:<[e-mail]>
2017-06-09 12:06:49 [karma] - recipients t: 1 (<[e-mail]>)
2017-06-09 12:06:49 - 550 too many recipients for karma -3 (h: )
2017-06-09 12:06:49 - dispatching DATA
2017-06-09 12:06:49 [naughty] - pass
2017-06-09 12:06:49 - 354 go ahead
2017-06-09 12:06:49 [dkim] - pass, valid signature, accept policy
2017-06-09 12:06:49 [dkim] - karma 1 (-2)
2017-06-09 12:06:49 [dmarc] - pass
2017-06-09 12:06:49 [dovecot_quota] - ok, quota-status returned: action=OK
2017-06-09 12:06:49 [bogus_bounce] - pass, not a null sender
2017-06-09 12:06:49 [bounce_stamp] - pass, not a null sender
2017-06-09 12:06:49 [attachments] - Number of parts: 2 (17 Kb)
2017-06-09 12:06:51 [spamassassin] - pass, Ham, 1.1 < 55, learn=no
2017-06-09 12:06:51 [virus::clamdscan] - pass, clean
2017-06-09 12:06:51 [naughty] - pass
2017-06-09 12:06:51 [queue::extended_qmail] - (for 27211) Queuing to /var/qmail/bin/qmail-queue
2017-06-09 12:06:51 - 250 Queued! 1497010011 qp 27213 <[e-mail]>
2017-06-09 12:06:51 - dispatching QUIT
2017-06-09 12:06:51 - 221 mail.tilly.se closing connection. Have a wonderful day.
2017-06-09 12:06:51 - click, disconnecting

[Alexander]

Maybe this could help?

https://github.com/smtpd/qpsmtpd/issues/267

[SH]

Thanks for reporting! I will fix that. Right now we are using karma deliberately only as positive signal rather than negative (eg. skip earlytalker plugin for well behaved mail servers).

[Henrik Tilly]

Thanks!

[SH]

fix #205 removing karma recipients check

→ <<cset e9d803844f09>>