Client side only incompatible with Trinkets.

[Former user]

When running Mambience 4.0.2 client only and connecting to a server that uses the Trinkets mod (https://www.curseforge.com/minecraft/mc-mods/trinkets-fabric), the additional Trinket slots do not work. They do start working when you enter a nether portal, but as soon as you disconnect, and reconnect, the trinket slots are no longer working. Items that shift-click into the trinkets slot while the slots are missing will crash the client.

The Trinket slots do work again when adding Mambience to the server.

[André Schweiger]

Are you sure Mambience is the cause of your issues? This mod does not touch any inventory related code so I really cannot see how it would cause issues. Even more so if adding Mambience to the server seemed to fix it as the clientside mod stays enabled and just doesn’t run the update loop in that case. Without more information I won’t be able to do much.

As you described atleast one case of the client crashing please include an error log to aid in finding the cause.

[Zhyn]

Here is the crash report and log. I tested several times on a fresh server/client install only using fabric-api, cloth config, modmenu, trinkets, icarus (any mod that uses trinkets slots will have the same bug), and mambience.

Crash report https://paste.md-5.net/afevilupow.cs Log https://paste.md-5.net/tasuravano.sql

It’s just weird that running Mambience on the server seems to fix the issue, which lead me to think it was an Mambience issue. Let me know If I should report to trinkets instead.

‌

[André Schweiger]

Managed to recreate the bug, though I did not find the cause yet

[André Schweiger]

I think I found the cause, working on a fix now

[André Schweiger]

Fix #34 (Issues in other mods using Fabric API to register data reload listeners (i.e. Trinkets) caused by clientside data loading)

→ <<cset 5c686b25324a>>

[André Schweiger]

Thank you for your report.

The issue was actually caused by how Fabric API implements resource reload listeners (for resource-/datapacks) which added them even to my custom clientside data loading code. So this issue had the possibility of affecting all kinds of other mods, not just trinkets.

I implemented a quick fix by avoiding to call the code the API mixes into which should be available as Version 4.0.3 soon. (Once CurseForge approves the file)