Latest ASE breaks Amp.load

Issue #230 resolved
andrew_peterson repo owner created an issue

A recent ASE change to how label works broke Amp.load. In short, the old version of ase.calculators.calculator.Calculator always called set_label during __init__, and we had added some functions to set the logger’s label within set_label. The new version no longer calls set_label but instead uses a setter/getter approach.

The question is how we update this; do we just make Amp work with the latest version of ASE (easiest), keep some backwards compatibility (possibly messy), or alert ASE that this broke our code (not clear if that’s needed).

Comments (1)

  1. Log in to comment