angelleye / PayPal IPN for WordPress / issues / #40 - jQuery needs to be enqueued properly — Bitbucket

Issue #40 closed

Former user created an issue 2015-03-20

Related to issue ~~#17~~.

The jquery should be moved to separate .js file; use wordpress to load it instead of spitting it out inline.

Comments (9)

Drew Angell repo owner
Jignesh, a buddy of mine brought this to my attention. Please make sure we use WP enqueue rather than placing jQuery code directly in PHP files. Keeps things cleaner.
- 2015-03-21T00:30:44+00:00
Drew Angell repo owner
- changed milestone to 1.0.2
- 2015-03-22T19:18:06+00:00
Drew Angell repo owner
- changed milestone to 1.0.4
- 2015-03-22T19:18:17+00:00
jignesh kaila
use WP enqueue, ref ~~#40~~

→ <<cset 4a10c5294afb>>
- 2015-03-23T12:05:37+00:00
jignesh kaila
remove mail function, ref ~~#40~~

→ <<cset 66937fe10c28>>
- 2015-03-23T12:09:03+00:00
jignesh kaila
change comment, ref ~~#40~~

→ <<cset 1ae8a4a5f6a9>>
- 2015-03-23T12:10:20+00:00
jignesh kaila
I am done with this and push to Issue ~~#40~~ for your review.
- 2015-03-23T14:07:34+00:00
Drew Angell repo owner
- changed status to closed
I had a merge conflict on this when I merged into the development branch, but I'm pretty sure I resolved it successfully.
- 2015-03-24T03:55:48+00:00
Drew Angell repo owner
- removed milestone
Removing milestone: 1.0.4 (automated comment)
- 2015-04-30T11:23:50+00:00
Log in to comment

Assignee: –

Type: enhancement

Priority: major

Status: closed

Version: –

Votes: 0

Watchers: 2