No unapproval on PR where only commit message has changed

[Eero Aaltonen]

EDIT: my first testing failed due to human error.

Apparently with Auto Unapprove Pull Requests version 3.0.2:

A forced update changing existing commits on a Pull Request (PR) did not trigger automatic un-approval.

The diff of the PR did not change, but commit messages did change. A developer reported this to me as a bug.

[Eero Aaltonen]

Reproducible with Auto Unapprove Pull Requests version 3.0.2:

A forced update changing existing commits on a Pull Request (PR) behaves as follows:

• When commit message was changed, automatic un-approval was triggered
• When commit message was not changed, automatic un-approval was not triggered (bug).

[Kristy Hughes]

This is expected behaviour as a result of issue #14. The plugin does not unapprove reviewers if the changes did not change the diff that has been reviewed.

[Kristy Hughes]

You may want to watch this suggestion which asks for an option to unapprove on any commit, not just meaningful ones.