unapprove didn't trigger on forces push

[Former user]

Sometimes it happens us - regardless of version of Bitbucket/AUP. Right now we got BB 6.5.0 + AUP 4.0.2. I think it's high time to raise issue. No stacktrace in logs.

[Andrzej Talarek]

Sorry, didn’t login before raising issue. Pushed was forced not forces ofcourse :).

[Kristy Hughes]

Hi @{557058:6709f3fd-0b7f-4688-9731-9b2ab4d543a3} ,

Can you please elaborate on the type of changes that happen in this force push? I’m not able to reproduce this bug.

Is it possible that the diff doesn’t get changed in the push?

Regards,

Kristy

[Kristy Hughes]

Hi,

Since it seems that this issue is expected behaviour as a result of issue #14 I will close this. You may want to vote and watch and vote for #19 which asks to add an option to unapprove even when the push did not contain changes to the diff.

Please let me know if your force push actually contained changes to the diff and we can reinvestigate.

Regards,

Kristy

[Andrzej Talarek]

I analyzed my case and I don’t think it should be closed. Below are changes in our code.

Old commit:

‌

New commit:

‌

You can see, that one space was removed. How do you compare changes when deciding whether or not unaproove?

Spaces are content of change and are essential - esspecially in languages like python.

I understand, that no content changes at all (just squash or change of commit comment) can be ignored by plugin (although I disagree), but why do you ignore content changes?

[Andrzej Talarek]

Hello? Anybody? Any comment?