Auto unapprove won't work if the new push is for binary file (excel file)

[Welly Hong]

Auto unapprove won’t work if the new push is for binary file. Such as excel file.

[Troy Germain]

@Kristy Hughes Is there a way for me to submit this as PR? or can you take the change from here?

‌

Let me know if there is anything I can do to help get this moving.

‌

Thanks

[Kristy Hughes]

@Troy Germain You should be able to open a PR by going to the create PR page in your fork and then selecting this repository as the target repository

[Troy Germain]

@Kristy Hughes I found my issue I couldn’t figure out how to fork the repository, first time using bitbucket.org figured it was locked down in an odd way. Sorry for the confusion.

I put in a PR and added you as a reviewer since you had the most recent work on this repo.

https://bitbucket.org/atlassian/stash-auto-unapprove-plugin/pull-requests/37/treat-all-files-as-text-to-trigger-for/diff

Pleas let me know if I should do anything else.

Thanks

[Kristy Hughes]

Thanks @Troy Germain I’ll take a look at it as soon as I get the chance

[Bryan Turner]

Can someone define what “won’t work” means, in this context? It’s not very descriptive. Does the pull request get unapproved even though it “shouldn’t”? Or does it not get unapproved even though it “should”?

[Troy Germain]

Sorry, I believe the wording does get a little rough. When only binary files are changed, the auto-unapprove plugin does not remove approvers. However, this seems like unintended behavior, since a commit was made that changed a file in an open PR with existing approvals. This is a result of the default behavior of git diff with relation to binary files.

[Welly Hong]

@Troy, thank you for clarification. The auto-unapprove plugin didn’t remove approver(s) when binary files(excel) are changed.

[Bryan Turner]

Version 4.0.3 has been released to Marketplace with a fix for this issue.