All comments are not syncing

Issue #326 closed
Former user created an issue

Comments on source files which were updated (commit) after a PR has been created do not appear to sync to the plugin.

Comments (10)

  1. Former user Account Deleted reporter

    This appears to be limited to situations where you make a comment on the web UI while reviewing diff under “n commit(s) since last viewed”.

  2. Former user Account Deleted reporter

    This may actually be a larger Bitbucket issue. When switching from the “n commit(s) since last viewed.” to the “All changes in this pull request” the comments disappear on the files even in the web UI. However, they still appear in the “Overview” page of the Web UI while never appearing in the “Details” page of the plugin.

  3. Pramod Busam Account Deactivated
    • The extension only supports comments on the effective diff, that is the diff in All changes in this pull request
    • When switching from the “n commit(s) since last viewed.” to the “All changes in this pull request” the comments disappear on the files even in the web UI - I believe that's by design. Commit-level comments are only valid for that particular commit and do not show up under all changes.

    Let us know if this answers your question.

  4. Former user Account Deleted reporter

    The diff view defaulted to “n commit(s) since last viewed.” and someone commented. Then the comment is lost to others because it was against a specific commit? That’s… kinda crappy default behavior.

  5. Alastair Wilkes

    Indeed, this highlights the importance of the "Overview" tab in Bitbucket Server, which is the one place you can view all of the comments on a PR. We will look into adding a similar overview in the extension to make these PRs easier to review with the extension (we currently don't plan to add commit/commit-range filtering to the extension due to UX constraints within VS Code). More broadly, there is an open request for improving the UX in Bitbucket Server itself which you can subscribe to here: https://jira.atlassian.com/browse/BSERV-7534

  6. Former user Account Deleted reporter

    Yep, I have another ticket opened here WRT difference between how comments are shown in “Overview” on Web UI and “Details” in plugin.

  7. Log in to comment