1. Atlassian Labs
  2. Atlassian Labs
  3. reviewmaster-plugin

Overview

goals:

  • all code that gets committed has at least two pair of eyes looking at it
  • as easy as possible to use and stay on top of
  • support reviews on pull requests for precommit reviews

non-goals:

  • precommit reviews on all commits
  • integration with gatekeeper

technical goals:

  • multitenant
  • p3 plugin on heroku
  • based on bitbucket

scenarios:

  • as a project dev, i want to see all the commits i haven't reviewed
  • as a project dev, i want quick access to commits i haven't reviewed
  • as a project admin, i want to see all commits that haven't been reviewed
  • as a project admin, i don't want to see trivial commits
  • as a project admin, i want to be notified when a commit hasn't been reviewed for more than a week
  • as a project dev, i want to see a comment activity stream
  • as a project dev, i want to see the "hottest" reviews
  • (as a project dev, i want to be able to assign other project devs as reviewers for a commit)

processes:

  • dashboard display (anon)
  • user requests project tab from plugin
  • plugin takes project id and makes rest call to lookup bb repo via applinks
  • p3 calls bb to retrieve commit info (limit to last 50 commits until we can mirror)
  • p3 delivers to browser via bigpipe

  • dashboard display (user)

  • needs to manage oauth

implementation:

ringojs/p3/heroku

  • project tab
  • view issue tab
  • bigpipe fed