revid/senders.go: modify senders to take logging.Logger interface as argument instead of log(level,msg,args) function signature
Issue #343
resolved
We now have a preference to use the logging.Logger interface in our codebase for logging given that the interface provides clear methods for different levels of logging i.e. Debug(), Info() Warning() etc which eliminates the need to define/reuse use consts to specify the log levels. In addition, the caller skip applied to the csvlogger (an implementation of the Logger) only works for calls to the level based methods, therefore we should update the sender code to do this otherwise logging is broken.
Comments (3)
-
-
reporter - edited description
-
reporter - changed status to resolved
Merged in fix-senders-logging (pull request #482)
revid/senders.go: using logging.Logger interface
resolves issue
#343Approved-by: Trek Hopton
→ <<cset 0d5100b2c88f>>
- Log in to comment
Is there a reason to do this?