rtmp: panic when given url is incomplete

[Saxon Milton]

I noticed that if I give rtmp.Dial a dodgy url, like "rtmp://a.rtmp.youtube.com/live2" we get a panic in parseURL, line 86. If we were to change a param remotely and messed this, it would cause revid to crash. It could be debated that revid should check the validity of the url though.

[Alan Noble]

I agree that parseURL should handle this.

[Saxon Milton]

Fyi, Dan just fixed this in PR #170

[Alan Noble]

I made a further improvement. It was not returning an error when it should have.

[kortschak]

I meant to raise this this morning. I noticed that you error on rtmp://addr/ where I didn't. That should be added, I think.

[Alan Noble]

Yes, the rtmp://addr case should be considered invalid, just like the next case rtmp://addr/

[Saxon Milton]

addressed in PRs #170 and #172