No warning or error for use of PGI compilers

When I tried PGI 18.4 on macOS today, I was surprised to find that there was no warning about the compiler being un-validated.

The compiler's --version output is

$ pgc++ --version

pgc++ 18.4-0 64-bit target on macOS -tp sandybridge
PGI Compilers and Tools
Copyright (c) 2018, NVIDIA CORPORATION.  All rights reserved.

And that appears to match the following "GOOD" pattern in utils/system-checks.sh

        elif echo "$CXXVERS" | egrep ' +\([^\)]+\) +([5-9]\.|[1-9][0-9])' 2>&1 > /dev/null ; then

We know PGI won't work at the moment (issue ~~#166~~).
So, I propose:

--- a/utils/system-checks.sh
+++ b/utils/system-checks.sh
@@ -80,6 +80,8 @@ platform_sanity_checks() {
             COMPILER_BAD=1
         elif echo "$CXXVERS" | egrep 'Apple LLVM version ([8-9]\.|[1-9][0-9])' 2>&1 > /dev/null ; then
             COMPILER_GOOD=1
+        elif echo "$CXXVERS" | egrep 'PGI Compilers and Tools'  > /dev/null ; then
+            COMPILER_BAD=1
         elif echo "$CXXVERS" | egrep ' +\([^\)]+\) +[1-4]\.' 2>&1 > /dev/null ; then
             COMPILER_BAD=1
         elif echo "$CXXVERS" | egrep ' +\(ICC\) +(17\.0\.[2-9]|1[89]\.|2[0-9]\.)' 2>&1 > /dev/null ; then

However, the pattern that did match looks waaaay to permissive to me.

Comments (2)