RFE: $(builddir)/bin/upcxx-run should honor UPCXX_PYTHON
$(builddir)/bin/upcxx-run
is very handy as a developer tool, but currently there is no way to use this script with a particular Python, aside from changing the default "python" in one's PATH.
Unlike the user-facing upcxx-run
, this is a shell script so cannot be passed to python directly (the recommended technique for end-user upcxx-run
)
The make run
target honors the value of UPCXX_PYTHON
passed as an argument to make (with the default being the one detected at configure time), but the shell script does not do this. UPCXX_PYTHON
is only consulted by the python script itself if it starts up with a too-old interpreter.
It would be nice for the shell script to honor $UPCXX_PYTHON
when set, possibly defaulted to the configure-time value (if it was set).
Comments (5)
-
-
Still untested, but pretty sure the following is also required.
--- a/bld/Makefile +++ b/bld/Makefile @@ -235,7 +235,7 @@ do-upcxx-run: force define upcxx_run_body #!$(UPCXX_BASH) export GASNET_PREFIX='$(builddir)/$(GASNETDIR)' -exec $(UPCXX_PYTHON) '$(top_srcdir)/utils/upcxx-run' "$$@" +exec $${UPCXX_PYTHON-$(UPCXX_PYTHON)} '$(top_srcdir)/utils/upcxx-run' "$$@" endef # Body of a upcxx wrapper in a build dir
-
Diffs above now tested and proposed as soln in pull request 188
-
- changed status to open
-
- changed status to resolved
Honor $UPCXX_PYTHON in in-build-tree upcxx-run
This commit honors
$UPCXX_PYTHON
if it is set in the environment when runningbin/upcxx-run
in a build tree. When not set, the configure-time value of the same (or--with-python=...
) is still used.Resolves issue 341
→ <<cset 693d3895a3cc>>
- Log in to comment
This in-build-tree
upcxx-run
already honors the configure-time value.The following untested patch makes that secondary to the
$UPCXX_PYTHON
in the environment when run.