Issue177: Fix regression on Non-fetching binary atomic operations
Dan Bonachea
Branch: bonachea/upcxx:issue177
bonachea/upcxx:issue177
Branch: berkeleylab/upcxx:develop
berkeleylab/upcxx:develop
Merged
#55 · Created  · Last updated
Merged pull request
Merge pull request #55 into develop
ed40c2e·Author: Dan Bonachea·Closed by: Dan Bonachea·2018-10-29
Description
Summary
Non-fetching binary atomic operations (eg atomic_domain::add) are broken in the 2018.9.0 release - a bug in their completion handling introduced in f1c5aaf2 makes them effectively unusable. This is a regression relative to the previous release.
The first commit below also serves as a 3-character hotfix that users could apply to the installed header.
Commits
fix issue #177: Completion broken for non-fetching binary AMOs
This fixes a think-o in the implementation of UPC++ atomic_domain binary non-fetching operations that causes compile errors on all forms of completion, making them effectively unusable.
issue #177: enhance test/atomics.cpp to detect the problem
Summary
Non-fetching binary atomic operations (eg
atomic_domain::add) are broken in the 2018.9.0 release - a bug in their completion handling introduced in f1c5aaf2 makes them effectively unusable. This is a regression relative to the previous release.The first commit below also serves as a 3-character hotfix that users could apply to the installed header.
Commits
fix issue #177: Completion broken for non-fetching binary AMOs
This fixes a think-o in the implementation of UPC++ atomic_domain binary non-fetching operations that causes compile errors on all forms of completion, making them effectively unusable.
issue #177: enhance test/atomics.cpp to detect the problem