Wrong logic in Zap/Zap+Exit in EPG channel selection

The EPGs have a settings for the OK button (short) and OK button (long) for choosing Zap or Zap+Exit for the button.

The logic for selection of the correct action in the implementation in EpgSelection.EPGSelection.OK() and OKLong() is incorrect, and does not properly separate the choices made for different EPGs.

If you change the menu setting for OK button (short) from its default Zap to Zap+Exit for the Graphical EPG, the action for OK changes as expected. If you then open another EPG style (say Multi EPG), its menu setting for OK button (short) will still be Zap, but if you press OK, the actual function executed is 'Zap + Exit', the setting for the Graphical EPG. The same happens for all other EPG styles that implement Zap/Zap+Exit for OK/long-OK.

The settings should either be correctly implemented for individual styles of EPG, or be made a single setting in MENU>Settings>TV>EPG Settings.

Reproduction steps

Starting with the factory default settings OK button (short)=Zap and OK button (long)=Zap+Exit in all EPGs, go to Graphical EPG>Menu, and change OK button (short)=Zap+Exit. Now in Graphical EPG, (short) pressing OK will no switch to the selected channel and exit the EPG. This is the expected behaviour.

Now go to, say, the Multi EPG, press MENU and its setting remains OK button (short)=Zap. Return to the Multi EPG, navigate to a different channel, and press OK. The selected channel becomes the current channel and the EPG is exited. With OK button (short)=Zap for the EPG, short OK should just switch the current channel to the selection and should not exit the EPG.

Comments (3)