Second infobar can't be disabled

The setting MENU>Setup>System>OSD Settings>2nd Infobar has no effect. Two presses of OK from live TV will always show the second infobar (with event synopsis information), whether the setting is on or off. Switching the setting off doesn't even remove 2nd infobar timeout from the settings screen.

The problem is most likely due to a change in the code of Components.InfobarGenerics.InfoBarShowHide.toggleShow() in July so that it now tests

elif self.secondInfoBarScreen and config.usage.show_second_infobar.value != "none" and not self.secondInfoBarScreen.shown:

where the test used to be

elif self.secondInfoBarScreen and config.usage.show_second_infobar.value and not self.secondInfoBarScreen.shown:

In March, this config variable changed its type from ConfigSelection to ConfigYesNo, so the type of config.usage.show_second_infobar.value is now Boolean and the comparison show_second_infobar.value != "none" will always be True snice the comparison is between different types.

There is other code in Components.InfobarGenerics that also assumes that show_second_infobar is still a ConfigSelection, and compares it to various strings. When the main part of this bug is fixed, these other incorrect uses of config.usage.show_second_infobar should also be removed.

Reproduction steps

Change MENU>Setup>System>OSD Settings>2nd Infobar to off.

The 2nd infobar timeout setting remains displayed.

Press GREEN OK to accept the setting.

Exit back to live TV.

Press OK twice. The second infobar is still displayed.

Comments (3)