YELLOW Timer Type in Timer entry screen doesn't update the screen display of Timer Type

Issue #345 resolved
prl created an issue

In the Timer entry screen, if the highlight is not on the Timer Type screen entry and you press YELLOW Timer Type, the Timer Type entry display doesn't change until the focus moves to the Timer Type entry.

Similarly, if the highlight is on Timer Type and you press YELLOW Timer Type, the timer type doesn't change until the focus moves onto the Timer Type entry. If the focus is on the Timer Type entry and you press YELLOW Timer Type, the timer type doesn't change until focus moves off the Timer Type entry or you change the Timer Type by using LEFT or RIGHT.

If you press LEFT or RIGHT after YELLOW while focus is on Timer Type, the effects of YELLOW and the LEFT/RIGHT are both applied at once when you press the navigation key. So if you start with Timer Type "record" YELLOW does nothing by itself, but if you then press RIGHT, you go straight to "zap" without visibly going through "zap and record". If you start in "record" and press YELLOW, LEFT, it stays in record, having invisibly gone to "zap and record" on YELLOW, then back to "record" on LEFT.

The bug isn't specific to setting timers from the EPG, nor is it only on adding timers. It also happens if you set a timer from MENU>TV/Radio/Timers, or if you edit an existing timer.

The code for YELLOW Timer Type doesn't seem to be triggering the UI display of the screen item to reflect the new value. The value is being updated, because if you press YELLOW Timer Type, then GREEN OK, then open the timer for editing, it also shows the updated value.

Reproduction steps

Basic case: from live TV, MENU>TV/Radio/Timers, GREEN Add timer. When the Timer entry screen appears, press YELLOW Timer type. The Timer type screen entry doesn't change. Then navigate down to the Timer type entry. As soon as the focus is on Timer type, the entry value updates.

While still with the focus on the Timer type entry, press YELLOW Timer type. The entry does not update. Then navigate off the Timer type entry and its display will update.

Other entries ad lib.

Comments (2)

  1. Peter Urbanec

    Fix Bug #345 new - YELLOW Timer Type in Timer entry screen doesn't update the screen display of Timer Type

    In Screens.TimerEntry.changeTimerType(), self.timerJustplayEntry was being set to a tuple that didn't match its original definition, so the lookup in self["config"].invalidate() was failing.

    The assignment to self.timerJustplayEntry was unnecessary, so it was simply removed.

    → <<cset 0d0600539b9a>>

  2. Log in to comment