You Tube main screen button labelling incorrect and other UI problems

[prl]

The You Tube main screen [MyTubePlayerMainScreen] has similar problems to the ones described for the Webcam travelcams page (bug #350).

The show()/hide() method calls on the button hint Button objects is ignored because the Button text is initialised at the time the Buttons are created. This means that the button hints don't reflect which buttons are active in the different states of the screen.

Also, the "Info" hint text on the BLUE button is applied as an eLabel from the easy-4-ui skin (and is missing completely from the class's embedded skin). The label is also not centred correctly in the easy-4-ui skin. This text should be revealed and hidden in different states of the screen.

The widget definition for the VKeyIcon in the easy-4-ui skin is incorrect with position 0,0 and size 0,0, and no other attributes (especially no pixmap attribute), so the TEXT button hint is never shown with this skin (the embedded skin has a definition for the VKeyIcon widget, but the widget still fails to display).

Mappings for action name showVirtualKeyboard have been put in the ActionMaps, but without the VirtualKeyboardActions context. That means that they never map. They appear to work after a fashion, but that is because the key presses are falling through to the VirtualKB ActionMap in [ConfigListScreen]. This can be clearly seen because the action method in [MyTubePlayerMainScreen] for showVirtualKeyboard places a different title in the virtual keyboard from the action method in [ConfigListScreen]. The separate keymap config_actions in [ConfigListScreen] is enabled and disabled separately from the VirtualKB action map. This means that the virtual keyboard is active in states where SMS-style entry into the search field is not allowed.

The search history state (YELLOW History) is poorly distinguished from the state for browsing the feed list. The search state is not distingushed at all from the browsing state. There is code to display the SMS HelpWindow, but that doesn't seem to be working correctly.

Reproduction steps Really, no more than go to MENU>Videos>You Tube, and move around in the interface (CH+/- switches between the feedlist and search entry), or press history, and compare which coloured buttons are active with the texts on the button hint. Also compare when the TEXT button is active with when the number buttons enter characters in the search box.

[prl]

Part of the problem with the screen state not being reflected in the screen is that when the HTTPConnection is created in [MyTubeService], a no longer supported debug option is used, so the connection to Google's suggestion service fails.

[Peter Urbanec]

Fix Bug #351 - [IniMyTube.ui] Add class names uniformly to debug output

→ <<cset d8cb856a46b9>>

[Peter Urbanec]

Fix Bug #351 - You Tube main screen button labelling incorrect and other UI problems

[MyTubePlayerMainScreen] Move initialisation of text in buttons to LayoutFinished time, so that later hide()/show() operations on the buttons work correctly.

Change the skin and other definitions of the BLUE button to be the same as other buttons/button hint.

Make hide()/show() operations on the buttons consistent with the actual enabling/disabling of the screen's aActionMaps.

Requires supporting skin changes in commit 7e973ac in branch Fix-bug-351 in skin-default repository.

→ <<cset aa71a26e2c90>>

[Peter Urbanec]

Fix Bug #351 - You Tube main screen button labelling incorrect and other UI problems

[MyTubePlayerMainScreen] Normalised text input to search box and enabled correct display of TEXT button hint and SMS-style input help window. The old code allowed SMS-style input to the search box only when it was enabled (CH+ from browsing feedlist), but the TEXT button was active to open the on-screen virtual keyboard in all contexts except the search history list.

The code that was intended to add opening the on-screen virtual keyboard didn't actually work, the opening of the on-screen keyboard fell back to the ActionMaps in [ConfigListScreen].

Made text input only active when the search box is active, and display the TEXT button hint and the SMS hint window when text input is active.

[MyTubeService.GoogleSuggestions] The code made use of an apperrently outdated way to enabling debugging in HTTPConnection. This caused Google suggestions to fail, so that no suggestions were presented in [MyTubePlayerMainScreen]. Changed the debug level setting to reflect the current API for HTTPConnection.

Requires supporting skin changes in commit 7e973ac in branch Fix-bug-351 in skin-default repository.

→ <<cset ba492b08389a>>

[Peter Urbanec]

Merged in prl/easy-ui-4/Fix-bug-351 (pull request #78)

Fix Bug #351 - You Tube main screen button labelling incorrect and other UI problems

→ <<cset abf753b3916a>>