- marked as trivial
Incorrect "save settings" warning when exiting Movie Player config
Issue #370
resolved
The Movie Payer config screen (from live TV, MEDIA, MENU>Settings...) displays a "Really exit without saving settings?" on exit, when no settings were changed.
From live TV, MEDIA, MENU>Settings... Make no changes to the settings. EXIT. "Really exit without saving settings?" is displayed.
Comments (3)
-
reporter
-
reporter
- changed status to resolved
Fix Bug
#370: Incorrect "save settings" warning when exiting Movie Player configConfigNumber is passed an integer as its default. It then passes that directly to ConfigText as its default and that is saved in ConfigText as an integer, when it should be a string. When ConfigNumber.isChanged() compares the current value with the default, it compares the string current value with the integer default, and they always compare unequal, even when they represent the same number.
That causes the "Disk space to reserve" item in Menu Player's Settings screen to always indicate that it has been changed.
Convert the default parameter to ConfigNumber to a string when it is passed to ConfigText.
→ <<cset 6987a439570b>>
-
reporter
Merged in prl/easy-ui-4/Fix-bug-370 (pull request #96)
Fix Bug
#370: Incorrect "save settings" warning when exiting Movie Player config→ <<cset af32d1d41b15>>
- Log in to comment
Lowering priority. There is no loss of functionality.