Pressing HELP during playback in Movie Player causes crash

[prl]

The name of option config.usage.on_movie_exit was changed to the more descriptive usage.pip_hideOnExit (during the 4.4 merge?), but the instance of config.usage.on_movie_exit in the help generation method InfoBar.MoviePlayer._helpLeavePlayerOnExit was not changed, so when it is called in the HelpList setup for MoviePlayer, it crashes.

I have a fix for this ready to submit to the repository.

Reproduction steps

Press MEDIA in live TV, then start recording or media file playing. Press HELP. Crash.

[Peter Urbanec]

Fix Bug #384 - Pressing HELP during playback in Movie Player causes crash

The name of config variable config.usage.on_movie_exit.value appears to have changed to config.usage.pip_hideOnExit.value in the 4.4 merge, but wasn't changed in InfoBar.MoviePlayer._helpLeavePlayerOnExit.

→ <<cset 5700a2d033ff>>

[Peter Urbanec]

Merged in prl/easy-ui-4/Fix-bug-384 (pull request #101)

Fix Bug #384 - Pressing HELP during playback in Movie Player causes crash

→ <<cset 2c0c4fff4d74>>

[Peter Urbanec]

Fix Bug #384 - Pressing HELP during playback in Movie Player causes crash

The name of config variable config.usage.on_movie_exit.value appears to have changed to config.usage.pip_hideOnExit.value in the 4.4 merge, but wasn't changed in InfoBar.MoviePlayer._helpLeavePlayerOnExit.

→ <<cset a4e6bdcc7465>>

[Peter Urbanec]

Revert "Fix Bug #384 - Pressing HELP during playback in Movie Player causes crash"

This reverts commit a4e6bdcc746572bce0dc77829266b83317e55acd.

Commit to wrong branch.

→ <<cset 09cb72cbe192>>