Unzip in File Commander hangs if any of the files it's extracting already exist
If any files in a a ZIP file being unzipped by the File Commander already exist, the current option settings of the command run from the UI are for ZIP to ask the user what to do. This read from the user hangs and it appears in the UI that nothing has happened, but the unzip process remains hung in the background.
It would be fixed by passing unzip either '-n' (never overwrite) or '-o' (always overwrite) when it's run for an extraction. I think I prefer '-o'.
Reproduction steps
Copy a ZIP file to a convenient location on the T3.
In the T3 GUI, open the File Commander on the disk where the ZIP file is (e.g. MENU>Sources>T4), navigate to the folder containing the ZIP file, select it and press OK, and then select and press OK on "Unpack to current folder". The ZIP file should unpack and a completion popup will appear. Dismiss the popup with OK, or wait for it to time out.
If you use the command-line interface to look at the folder where the ZIP file is, you should see the unpacked contents of the ZIP file.
Then in the UI, press OK again. Nothing appears to happen, but if you run
ps ax | grep unzip
in the command-line interface, you'll see the suspended unzip process. If you press OK again in the UI, you'll see a second suspended unzip process.
ps ax | grep zip
Comments (3)
-
-
- changed status to resolved
Fix bug
#390: Unzip in File Commander hangs if any of the files it's extracting already existAdd "-o" option to unzip command to force over-write, instead of unzip asking whether to overwrite, as discussed in comments in bug
#390in the issue tracker.→ <<cset 64be459df9e4>>
-
Merged in prl/easy-ui-4/Fix-bug-390 (pull request #109)
Fix bug
#390: Unzip in File Commander hangs if any of the files it's extracting already exist→ <<cset 2786bfe5db3f>>
- Log in to comment
Agreed, overwriting existing files would be the expected behaviour.