Crashes in FileCommander when file browser panes show the device list

Issue #451 resolved
prl created an issue

In [FileCommanderScreen], the GUI crashes if MEDIA is pressed when either file browser pane shows the devices list. In [FileCommanderScreenFileSelect], the GUI crashes when EXIT is pressed if either file browser pane shows the devices list.

This bug is closely related to bug #245 and needs the same fixes in two other parts of the code.

Replication steps

First instance:

Enter the File Commander main screen using MENU>Setup>Sources / Files. In either file browser screen, navigate upwards until the devices list is shown in either of the two panes. Press MEDIA. Crash.

Second instance:

Enter the File Commander main screen using MENU>Setup>Sources / Files. In both file browser screens, navigate so that neither pane shows the devices list. Press MEDIA to enter the File Commander Multi-File Select screen. In this screen navigate in either pane until one of the panes shows the devices list (I was only actually able to do that in the left-hand pane). Press EXIT. Crash.

Comments (2)

  1. Peter Urbanec

    Fix bug #451: Crashes in FileCommander when file browser panes show the device list

    Protect two further cases of assignment to config.plugins.filecommander.path_left/right_tmp from assignment when self["list_left/right"].getCurrentDirectory() doesn't return a valid value.

    Related to fixes for bug #245.

    → <<cset 4c5907383a13>>

  2. Log in to comment