Channel selection move mode doesn't work correctly in single-bouquet mode

[prl]

If MENU>Setup>TV>Channel settings>Enable multiple bouquets is disabled, move mode in the Channel selection screen (FAV from live TV) doesn't work correctly.

If move mode is activated using FAV, MENU>Enable move mode (not by using MENU, 6), when OK is pressed to select a channel to move, the channel is selected as the current live TV channel and the Channel selection screen is exited.

If move mode is activated using FAV, MENU, 6, the current channel is preselected, and can be moved using UP/DOWN, but if OK is pressed, instead of deselecting the channel for move, the Channel selection screen is exited (and because the channel was the live TV channel anyway, the channel is unchanged).

The cause is in ChannelSelectionBase.isBasePathEqual(), where the test len(self.servicePath) > 1 should be len(self.servicePath) > 0.

I have a fix for this.

Replication steps

Disable MENU>Setup>TV>Channel settings>Enable multiple bouquets, and then restart the GUI to get the UI into a known state.

When the UI has restarted, from live TV press FAV, then MENU>Enable move mode. navigate to any channel, and press OK. Instead of highlighting the channel red as selected for move, the channel is selected for live TV and the Channel selection screen is exited.

[Peter Urbanec]

Fix bug #461: Channel selection move mode doesn't work correctly in single-bouquet mode

[ChannelSelectionBase]

In ChannelSelectionBase.isBasePathEqual(), change the test len(self.servicePath) > 1 to len(self.servicePath) > 0 to protect the access to self.servicePath[0].

Also changed form of isBasePathEqual() and isPrevPathEqual() to simply return the result of the logical expression instead of if expr: return True else: return False

→ <<cset d4b6915dafc1>>

[Peter Urbanec]

Merged in prl/easy-ui-4/Fix-bug-461 (pull request #208)

Fix bug #461: Channel selection move mode doesn't work correctly in single-bouquet mode

→ <<cset 2d52e2016ae4>>