Long-CH+/- changes both PiP and main screen channel, not just PiP

Issue #477 resolved
prl created an issue

Long-CH+/- is supposed to change the PiP channel without the need to change the zap focus to PiP. However, long-CH+/- changes both the PiP channel and the main screen channel, because the keymap.xml entries are for (make, repeat), when they should be separate entries for break and long.

Replication steps

The bug is most clearly shown when the PiP screen is not shown.

Note the current live TV main screen channel.

Long-press CH+ until the message "Please open Picture in Picture first" appears in a popup.

Check the main screen channel. It will have moved several channels on from the original position.

CH- behaves in a similar manner.

If the PiP screen is showing (but PiP is not the zap focus), on long-CH+, the PiP channel changes by one step and the main screen changes by several steps.

Comments (2)

  1. Peter Urbanec

    Fix #477: Long-CH+/- changes both PiP and main screen channel, not just PiP

    [keymap.xml]

    Use long/break codes for CH+/- instead of make/repeat to match the expectation of the code.

    [InfoBarGenerics]

    Add a toggle on long-press of CH+/- so that if the long press doesn't result in a new screen (like the "Please open Picture in Picture first" error popup) the "break" action for the button press doesn't get carried out.

    → <<cset 4be3fee2ac79>>

  2. Log in to comment