"Save timeshift" fails on standby when "Show warning when timeshift is stopped" is disabled

[prl]

If MENU>Setup>TV>Timeshift settings>Show warning when timeshift is stopped is disabled, and "save timeshift" is requested, timeshift is not saved on entering standby.

When standby is requested, either from the Power / Restart menu or from a POWER button press, the PVR enters standby, timeshift is stopped and no recording timer is started to record the remainder of the event and its padding. When the PVR restarts out of Standby, the error message "Timeshift save failed!/[Errno 2] No such file or directory: '/media/hdd/timeshift/pts_livebuffer_N.meta'" is displayed.

The timeshift buffer is not saved (not even the timeshift data that existed at the time of the standby request).

I think this bug should be resolved by correctly saving the timeshift buffer as the user requested.

Replication steps

Disable MENU>Setup>TV>Timeshift settings>Show warning when timeshift is stopped.

Return to live TV, and use REC>Select an event to save>Current event: ... to request that timeshift is saved.

Enter standby either using a POWER press tied to the Standby action or my using the Power / Restart>Standby menu action.

Standby is entered, timeshift is stopped and no recording timer is started. Timeshift can be checked by using ls -l /media/hdd/timeshift and checking that file sizes are not changing. The recording timer can be checked on a T3 or T4 by looking at the front panel indicators or by watching file sizes in /media/hdd/movie.

Use POWER to restart the PVR. A popup displaying the error message "Timeshift save failed!/[Errno 2] No such file or directory: '/media/hdd/timeshift/pts_livebuffer_N.meta'" is displayed.

Check the media browser - no saved timeshift file will be found.

[Peter Urbanec]

Fix Bug #494: "Save timeshift" fails on standby when "Show warning when timeshift is stopped" is disabled

[Timeshift]

Change the action of ptsGetTimeshiftStatus() so that it returns True if self.save_current_timeshift is True, whether config.usage.check_timeshift.value ("Show warning when timeshift is stopped") is True or not.

This has the side-effect of raising the "Recording(s) are in progress or coming up soon!" on shutdown (from POWER or from the Power / Restart screen) if a timeshift save has been requested even when "Show warning when timeshift is stopped" is disabled. I think that is desirable behaviour; it previously simply shut down in those conditions previously.

[Standby]

Changed the popup text from "Recording(s) are in progress or coming up soon!" to "Recording(s) are in progress or coming up soon, or you are saving timeshift!". Also changed the "You seem to be in timeshift!" popup text to "You seem to be in timeshift or saving timeshift!".

NB:

When a timeshift save has been requested, InfoBarTimeshift.checkSavingCurrentTimeshift() incorrectly sets config.timeshift.isRecording to True. This means that the "Recording(s) are in progress ..." popup text is used when the "You seem to be in timeshift ..." text should be displayed. The text for the "Recording(s) are in progress ..." popup should be "Recording(s) are in progress or coming up soon, or a timeshift merge is pending!" if the setting of config.timeshift.isRecording was correct.

The setting of the timeshift save variables will be overhauled in the fix for Bug #491: Unnecessary delays in performing merge when saving current event's timeshift.

→ <<cset f480c18e682f>>