Timeshift buffer doesn't start after channel change from EPG called from MoviePlayer

Issue #553 resolved
prl created an issue

If the EPG is opened when media or a recording is being played, and then live TV is entered by using the Zap channel change in the EPG entered from the MoviePlayer, the timeshift buffer isn't restarted on return to live TV. When this happens PAUSE and the "enter timeshift and skip back" buttons (LEFT and optionally DOWN) have no effect, and don't show the UnhandledKey popup.

Note that this bug is specific to selecting the channel with the Zap (short-OK) action. Using long-OK Zap+Exit causes a different bug (see bug #554).

Replication steps

Assumes the default OK button (short) -> Zap and OK button (long) -> Zap+Exit settings of EPG, MENU.

From live TV, verify that timeshift is operating, then return to live TV.

MEDIA, navigate to a recording, OK to play.

While the recording/media is playing, EPG to open the EPG, and then navigate to any channel and short-OK, short-OK to zap to it and exit the EPG.

Control returns to live TV showing the selected service, but after the timeshift startup delay, the timeshift buffer does not start. PAUSE and the "enter timeshift and skip back" arrow buttons have no effect.

If /media/hdd/timeshift is checked, there are no timeshift.* files, indicating that the timeshift buffer has not been restarted.

Timeshift returns to normal if a new channel is selected (e.g. with CH+/-).

Comments (4)

  1. Peter Urbanec

    Fix bug 553: Timeshift buffer doesn't start after channel change from EPG called from MoviePlayer

    When InfoBarEPG.reopen() is a method in MoviePlayer and is called with parameter 'close', indicating that a service has been zapped to in EPGSelection, save the running service as self.lastservice (as in previous code) and then stop play.

    This means that when self.lastservice is played in MoviePlayer.__onClose(), self.lastservice will be restarted in the correct context so that its evStart event is directed to the InfoBar.

    → <<cset 6f8a075156b7>>

  2. Log in to comment