Timeshift control malfunctions after exit from MoviePlayer

If timeshift is started while in the MoviePlayer, on exit from the MoviePlayer, when timeshift is activated, only the timeshift functions on PAUSE, LEFT, DOWN (if enabled for skip) and REW function normally.

Buttons STOP, RIGHT, UP (if enabled for skip) and FF show the UnhandledKey popup and perform no action.

Live TV can only be exited by functions that bring up the "Leave timeshift" popup, like CH+/-.

The cause of the problem was adding code that started timeshift on the background live TV in MoviePlayer, in 25cb86c, the fix for bug ~~#530~~.

For some reason that I haven't been able to identify, starting timeshift in this context causes DVBServicePlay::updateDecoder() to fail to emit an evSeekableStatusChanged event when the user activates timeshift after exitting MoviePlayer.

The failure to emit the event then means that the switch to the button assignments that should happen when timeshift is activated do not occur.

Replication steps

Ensure that timeshift is enabled.

Set MEDIA, MENU>Settings>Show live TV when movie stopped to yes.

On return to the MovieSelection screen, start playing a recording or media file, then STOP to return to the MovieSelection screen.

Then wait at least the time to autostart timeshift, set in MENU>Setup>TV>Timeshift settings>Automatically start timeshift after, to ensure that timeshift is restarted while in the MovieSelection screen.

EXIT to return to live TV, then wait for a usable amount of timeshift to accumulate (a few minutes), then PAUSE.

Now PAUSE, LEFT, DOWN (if enabled for skip) and REW work as expected. STOP, RIGHT, UP (if enabled for skip) and FF show the UnhandledKey popup.

Exit timeshift by changing channels.

Comments (3)